Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated TCK test lists #1078

Merged
merged 4 commits into from Jun 27, 2022
Merged

Updated TCK test lists #1078

merged 4 commits into from Jun 27, 2022

Conversation

edbratt
Copy link
Contributor

@edbratt edbratt commented Jun 23, 2022

As described in #1077. Removed version numbers and referred to list in the respective Platform Specification documents.

CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @scottmarlow

Signed-off-by: Ed Bratt ed.bratt@oracle.com

…n numbers and referred to list in the respective Platform Specification documents.

Signed-off-by: Ed Bratt <ed.bratt@oracle.com>
Copy link
Contributor

@alwin-joseph alwin-joseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section 1.5 Additional Requirements seems to be untouched. Should we modify or remove that .

Update: Sorry I see that was updated.

Fixed Typo.
Copy link
Contributor

@scottmarlow scottmarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that more changes are needed for Activation, Mail, DSOL. I'll provide more feedback later but I think it would be better to separate the addition of these TCKs instead a separate pull request for further discussion that might also cover the (old) Authentication source repo issue as well (which is similar to Mail TCK imo).

Updated: Since GlassFish is able to pass the Standalone TCKs (Activation, Mail, DSOL) and we do not know of any problems with running these TCKs (any problems can be reported as TCK challenges), I will give my approval of this pull request after the minor typo is corrected.

@scottmarlow
Copy link
Contributor

It seems like the Activation 2.1 TCK doesn't work with WildFly, so created jakartaee/jaf-tck#55 TCK challenge for that. I'm hoping it is just a user mistake.

@scottmarlow
Copy link
Contributor

Also created jakartaee/mail-tck#47 to ensure that Java Mail 2.1 TCK can be used by all EE 10 implementations, including those that do no support JPMS. Further testing is needed to determine if the Mail 2.1 TCK can work with non-JPMS EE 10 implementations (as per EE 10 Platform requirements).

@scottmarlow
Copy link
Contributor

It seems like the Activation 2.1 TCK doesn't work with WildFly, so created eclipse-ee4j/jaf-tck#55 TCK challenge for that. I'm hoping it is just a user mistake.

Never mind. now passing thanks to @lukasj !

@edbratt edbratt merged commit c2a04b1 into jakartaee:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants