Fix some JPA TCK issues #1287
Merged
Fix some JPA TCK issues #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottmarlow
reviewed
Apr 22, 2024
lukasj
reviewed
Apr 23, 2024
...a/ee/jakarta/tck/persistence/se/schemaGeneration/annotations/discriminatorColumn/Client.java
Show resolved
Hide resolved
14 tasks
…sed through as system properties
beikov
force-pushed
the
tckrefactor-jpa-fixes
branch
from
cc70ead
to
bf44250
Compare
lukasj
approved these changes
Apr 24, 2024
gurunrao
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
I didn't create issues for these problems yet, but maybe that's not even necessary. We're in the process of certifying Hibernate ORM 7 against JPA 3.2 and these are some problems of the TCK that we encountered when testing with PostgreSQL.
Related Issue(s)
Describe the change
See the commit messages
Additional context
CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej
@starksm64 @scottmarlow