-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including permission.xml at ear level #137
Conversation
Signed-off-by: root <root@rohijjai-1.subnet1ad2phx.devweblogicphx.oraclevcn.com>
Signed-off-by: rohit.ku.jain rohit.ku.jain@oracle.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @RohitKumarJain for making this change!
@RohitKumarJain have you signed the Eclipse ECA with the email associated with your github account? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RohitKumarJain, as mentioned in previous comment, please signoff on the ECA agreement and I think then you might need to do a "git commit --amend --signoff" (and push change to github), to resolve the ECA check failure.
Hi @scottmarlow , I will be creating a new fresh PR. Apologies for inconvenience. |
Signed-off-by: root root@rohijjai-1.subnet1ad2phx.devweblogicphx.oraclevcn.com