Fix Issue 624 #647
Merged
Fix Issue 624 #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property jsp.commondir does not exist. It is not used anywhere else, nor is it defined anywhere. It appears to be a copy/paste error for jspcommon.dir which is already specified as an include dir for this compilation task. Signed-off-by: Mark Thomas <markt@apache.org>
The tests in this package depend on the common EL code so ensure it is compiled before the test is packaged. Signed-off-by: Mark Thomas <markt@apache.org>
scottmarlow
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
#624
Related Issue(s)
None
Describe the change
Add a missing compilation step required because some of the JSP TCKs tests depend on the common EL code so that code needs to be compiled before the associated JSP TCK test WAR is packaged.
I also included a commit that performs some clean-up of some unnecessary configuration I cam across while investigating this issue.
Additional context
None
CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman