Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPA Tests for JPQL EXTRACT support added in JPA 3.1 #775

Merged
merged 2 commits into from Jan 19, 2022

Conversation

Tomas-Kraus
Copy link
Contributor

@Tomas-Kraus Tomas-Kraus commented Nov 25, 2021

name: Pull Request
about: Create a pull request for a Platform TCK change
title: 'JPA Tests for JPQL EXTRACT support added in JPA 3.1'
labels: ''
assignees: ''


Fixes Issue
TCK Tests for jakartaee/persistence#314

Related Issue(s)
jakartaee/persistence#102

Describe the change
Tests for new JPQL EXTRACT grammar changes.

Additional context
N/A

CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @scottmarlow

Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com>
@Tomas-Kraus
Copy link
Contributor Author

Let's keep this as draft until PR jakartaee/persistence#314 is merged and new spec assertion IDs are generated.

Signed-off-by: Tomas Kraus <tomas.kraus@oracle.com>
@Tomas-Kraus
Copy link
Contributor Author

JPA spec assertion list update is part of PR 793.
JPA API 3.1.0-RC2 is in central. Test must be verified using this latest API.

@Tomas-Kraus Tomas-Kraus marked this pull request as ready for review January 18, 2022 15:16
@scottmarlow scottmarlow merged commit d6b67f0 into jakartaee:master Jan 19, 2022
@gurunrao
Copy link
Contributor

gurunrao commented Mar 3, 2022

@Tomas-Kraus - JPA standalone TCK has two failure for following tests

  • com/sun/ts/tests/jpa/core/annotations/access/field/Client.java#testExtractDateTimeQuarter
  • com/sun/ts/tests/jpa/core/annotations/access/field/Client.java#testExtractDateQuarter

@gurunrao
Copy link
Contributor

gurunrao commented Mar 8, 2022

@Tomas-Kraus - Please refer attached logs - jpatck.log for details on ^ test failures.

@Tomas-Kraus
Copy link
Contributor Author

This was already fixed in EclipseLink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants