TCK Migration: Move pending jaxrs/ee/rs/core,client,ext tests from jakartaee-tck #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in jakartaee-tck - Removed the build.xml files - Moved web.xml.template to corresponding resources folder
- rename packages - add missing classes/jar dependencies - assertFault change to assertTrue - deployment code, test run log
- add @test annotation - change assertTrue arguments to append as string - add classes or packages for archive deployable - JAXRSProvidersClientIT not to inherit core.application.JAXRSClientIT , duplicate test methods
alwin-joseph
force-pushed
the
tck-migration-ee.rs.core-client-ext
branch
from
f51c51b
to
3ff747b
Compare
spericas
approved these changes
Oct 15, 2021
jansupol
reviewed
Oct 18, 2021
jansupol
approved these changes
Oct 18, 2021
|
Merging in the interest of moving forward with the rest of the migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to migrate the pending tests from jaxrs/ee/rs/core,client,ext folders in jakartaee-tck
To test the changes :
export JAVA_HOME=<JDK11_HOME>
export M2_HOME=<MAVEN_HOME>
export PATH=$M2_HOME/bin:$JAVA_HOME/bin:$PATH
jaxrs-tck/
mvn clean install
jersey-tck/
run all tests : mvn clean verify -Parq-glassfish-managed
The tests migrated in this PR includes tests from below folders :
4 failures (tracked at #1020 ) :
jaxrs-tck/src/main/java/jakarta/ws/rs/tck/ee/rs/client/syncinvoker/JAXRSClientIT.traceWithResponseClassThrowsNoWebApplicationExceptionTest
jaxrs-tck/src/main/java/jakarta/ws/rs/tck/ee/rs/client/syncinvoker/JAXRSClientIT.traceWithGenericTypeResponseThrowsNoWebApplicationExceptionTest
jaxrs-tck/src/main/java/jakarta/ws/rs/tck/ee/rs/core/securitycontext/basic/JAXRSBasicClientIT.jbasicAuthorizationAdminTest
jaxrs-tck/src/main/java/jakarta/ws/rs/tck/ee/rs/core/securitycontext/basic/JAXRSBasicClientIT.basicAuthorizationStandardUserTest