New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jakarta POM fixes #100
Jakarta POM fixes #100
Conversation
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
I'm unsure about the automatic module name. My understanding is that we cannot yet add now ones with "java" prefix, and the existing ones will probably be changed to "jakarta" to ensure consistency. I'm all for adopting modularity but I sadly think we should keep that line out for this initial release |
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the Specification Vendor should still be Oracle Corporation, unless we had to keep that in EE4J_8 for consistency with Java EE 8, but then the groupId was also changed, so what should it be, Eclipse Foundation or something else?
We might have to go through quite a bunch of other projects, since it happens more often |
@keilw JAX-RS, which has published, has that too: https://github.com/eclipse-ee4j/jaxrs-api/blob/EE4J_8/jaxrs-api/pom.xml#L450 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This would have to be solved globally, not just for this PR and project
@keilw I dismissed the review, since we have 2 approvals, and this would be an EE4J wide issue and not something that applies to just this PR. Can you take this up with the PMC? We can then integrally change it to the new name in all spec projects. |
The vendor of the specification it implements is still Oracle (Java EE 8). I think it is correct. |
+1. Although the PMC is not being as responsive as I would have expected. I
recently asked about adding the module names (which was an interesting and
feasible feature IMO) and only @m0mus replied to show his concerns.
El vie., 12 oct. 2018 14:59, Arjan Tijms <notifications@github.com>
escribió:
… The vendor of the specification it implements is still Oracle (Java EE 8).
I think it is correct.
@ggam <https://github.com/ggam> I think so too. But if @keilw
<https://github.com/keilw> feels strongly about this, would be best to
git this sorted with the PMC, just to be sure.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#100 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACAucMbm9KuIzIFlXRa1pVXo_R3Fx6zGks5ukJIagaJpZM4XZSPi>
.
|
Signed-off-by: arjantijms arjan.tijms@gmail.com