Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta POM fixes #100

Merged
merged 2 commits into from Oct 12, 2018
Merged

Jakarta POM fixes #100

merged 2 commits into from Oct 12, 2018

Conversation

arjantijms
Copy link
Contributor

Signed-off-by: arjantijms arjan.tijms@gmail.com

Signed-off-by: arjantijms <arjan.tijms@gmail.com>
@ggam
Copy link
Contributor

ggam commented Oct 12, 2018

I'm unsure about the automatic module name. My understanding is that we cannot yet add now ones with "java" prefix, and the existing ones will probably be changed to "jakarta" to ensure consistency.

I'm all for adopting modularity but I sadly think we should keep that line out for this initial release

Signed-off-by: arjantijms <arjan.tijms@gmail.com>
keilw
keilw previously requested changes Oct 12, 2018
Copy link
Member

@keilw keilw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the Specification Vendor should still be Oracle Corporation, unless we had to keep that in EE4J_8 for consistency with Java EE 8, but then the groupId was also changed, so what should it be, Eclipse Foundation or something else?

@arjantijms
Copy link
Contributor Author

We might have to go through quite a bunch of other projects, since it happens more often

@arjantijms
Copy link
Contributor Author

@keilw JAX-RS, which has published, has that too:

https://github.com/eclipse-ee4j/jaxrs-api/blob/EE4J_8/jaxrs-api/pom.xml#L450

Copy link

@m0mus m0mus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjantijms
Copy link
Contributor Author

@keilw

so what should it be, Eclipse Foundation or something else?

I think Oracle for now? @m0mus ?

@arjantijms arjantijms dismissed keilw’s stale review October 12, 2018 12:51

This would have to be solved globally, not just for this PR and project

@arjantijms
Copy link
Contributor Author

@keilw I dismissed the review, since we have 2 approvals, and this would be an EE4J wide issue and not something that applies to just this PR.

Can you take this up with the PMC? We can then integrally change it to the new name in all spec projects.

@arjantijms arjantijms merged commit 215658e into jakartaee:EE4J_8 Oct 12, 2018
@ggam
Copy link
Contributor

ggam commented Oct 12, 2018

The vendor of the specification it implements is still Oracle (Java EE 8). I think it is correct.

@arjantijms
Copy link
Contributor Author

arjantijms commented Oct 12, 2018

The vendor of the specification it implements is still Oracle (Java EE 8). I think it is correct.

@ggam I think so too. But if @keilw feels strongly about this, would be best to get this sorted with the PMC, just to be sure.

@ggam
Copy link
Contributor

ggam commented Oct 12, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants