Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fix for #149 #150

Merged
merged 1 commit into from Oct 27, 2019
Merged

Proposed fix for #149 #150

merged 1 commit into from Oct 27, 2019

Conversation

ggam
Copy link
Contributor

@ggam ggam commented Oct 17, 2019

JASPIC -> AUTH
JACC -> AUTHZN

What do you think?

@keilw
Copy link
Member

keilw commented Oct 17, 2019

Just to be clear, AUTH would stand for "Authentication" and AUTHZN for "Authorization"?
The latter is a bit of a tongue-breaker, although "JASPIC" also wasn't quite something for people with loose dentures ;-D

@ggam
Copy link
Contributor Author

ggam commented Oct 17, 2019 via email

@arjantijms
Copy link
Contributor

Wherever possible, just write them out in full?

AuthorisationSpec and AuthenticationSpec?

Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
@ggam
Copy link
Contributor Author

ggam commented Oct 18, 2019

Changed to AUTHENTICATIONSPEC and AUTHORIZATIONSPEC

@keilw keilw requested a review from arjantijms October 21, 2019 12:55
@arjantijms arjantijms merged commit 365183e into jakartaee:master Oct 27, 2019
@arjantijms
Copy link
Contributor

@ggam A little late, but I just realised the other references are like SERVLET40, so I think it would be more consistent to go for AUTHENTICATION11 etc here. What do you think?

@bshannon
Copy link

It's annoying having to change the version numbers in all the URLs in all the references as
the spec is updated from version to version. If all of that could be defined in one place in
attributes or whatever then it would make sense for the reference to be just AUTHENTICATIONSPEC.

@arjantijms
Copy link
Contributor

It's annoying having to change the version numbers in all the URLs in all the references as
the spec is updated from version to version.

True. Might be a good idea to set some kind of recommendation for this at the platform level to ensure some level of consistency.

@ggam
Copy link
Contributor Author

ggam commented Nov 22, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants