Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change userinfoEndpoint in OpenIdProviderMetadata to optional #272

Merged
merged 1 commit into from Dec 12, 2022

Conversation

jimmy1wu
Copy link
Contributor

hello,

i'm proposing to change the userinfoEndpoint in OpenIdProviderMetadata from Required to Optional in its javadoc.

i think this will make it more aligned with the authentication mechanism spec since:

  1. it is not one of the required values under the Metadata configuration section.

The following metadata values are required (since they are defined as required by the OpenID Specification):

Authorization endpoint

Token endpoint

JWKS URI

Issuer of the tokens

Supported Subject types

Supported Response types

Supported Id Token Signing Algorithms

https://github.com/jakartaee/security/blob/master/spec/src/main/asciidoc/authenticationMechanism.adoc#metadata-configuration

  1. not all op's support the user info endpoint.

An implementation may choose to not implement the call to the User Info Endpoint, in all cases or when a certain configuration value is set, since not all OpenID Connect Providers support this User Info Endpoint.

https://github.com/jakartaee/security/blob/master/spec/src/main/asciidoc/authenticationMechanism.adoc#caller-name-and-groups

Signed-off-by: Jimmy Wu jimmywu0605@gmail.com

Signed-off-by: Jimmy Wu <jimmywu0605@gmail.com>
@arjantijms
Copy link
Contributor

I agree, but would like to see some feedback from other committers here.

@arjantijms arjantijms requested a review from ggam December 2, 2022 16:48
@arjantijms arjantijms added this to the 3.1 milestone Dec 2, 2022
@arjantijms arjantijms added the API label Dec 2, 2022
@arjantijms arjantijms merged commit 68a1a88 into jakartaee:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants