Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

82 annotation literals #83

Merged
merged 2 commits into from Jul 4, 2018
Merged

82 annotation literals #83

merged 2 commits into from Jul 4, 2018

Conversation

arjantijms
Copy link
Contributor

PR for #82 Add annotation literals for built-in annotations.

The following annotations made sense to have literals for them:

  • AutoApplySession
  • LoginToContinue
  • RememberMe

There are the interceptor binding annotations. The *Definition annotations are just plain (no CDI) annotations and don't need literals. We don't have qualifiers in EE Security (yet).

Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Copy link
Contributor

@ggam ggam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! As a side note, there are a lot of small formatting changes. It could make sense to make another PR just to unify formatting.

@arjantijms
Copy link
Contributor Author

As a side note, there are a lot of small formatting changes. It could make sense to make another PR just to unify formatting.

Ah, just noticed. It's the "automatically remove trailing whitespace" in my IDE. I'll make another commit soon then to unify that, and will attach the formatting preferences file. Thx!

@arjantijms arjantijms merged commit e57b08f into jakartaee:master Jul 4, 2018
@arjantijms arjantijms deleted the 82-annotation-literals branch July 4, 2018 19:10
@arjantijms arjantijms restored the 82-annotation-literals branch July 4, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants