Fix #407 add identifiers for debug logging #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregw
requested changes
Sep 17, 2021
gregw
approved these changes
Sep 20, 2021
|
@sbordet your thoughts on quic/h3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass. I think it is sufficient for 6.0 but I'm expecting suggestions for improvements.
An earlier draft tried to combine container generated IDs for protocols that didn't define them and protocol defined IDs for protocols that did. That didn't work too well primarily because the h2 stream ID is not unique. Working around that quickly got messy and separating out container generated IDs and protocol IDs was the neatest solution I can find.
I'd have no objection to including remote/local address and port at this stage and maybe some additional TLS details as well.
Thoughts?