Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta EE 8 challenge, permissions.xml must also be added to EAR level #131

Closed
scottmarlow opened this issue Jan 7, 2020 · 5 comments
Closed
Assignees

Comments

@scottmarlow
Copy link
Contributor

Hi,

A few months ago, I created a TCK challenge Jakarta-tck issue#132 that has been addressed in the Jakarta TCK project source and should be included in the 8.0.2 Platform TCK.

I'm opening this issue now, to represent the challenge, as required by the TCK process document, as we should follow the defined process.

Since the TCK is already updated to address this challenge, the challenge should be accepted. This is not exactly the action suggested by the TCK process document, so perhaps the process document should be amended to allow resolution via code changes as well as test exclusion?

@scottmarlow scottmarlow changed the title challenge Jakarta EE 8 challenge, permissions.xml must also be added to EAR level Jan 7, 2020
@starksm64 starksm64 self-assigned this Jan 7, 2020
@starksm64
Copy link
Contributor

I would think we would still want a challenge as the basis for justifying a code change no? It looks like there was some failing behavior that warranted the tck #132 issue. Perhaps we can say that a bug report with a code change that also has a challenge label can be accepted in place of a challenge specific issue.

@scottmarlow
Copy link
Contributor Author

I agree with the idea of amending to say that a bug report with a code change that also has a challenge label can be accepted in place of filing the challenge with the specification project’s issue tracker.

A separate issue is that I couldn't add a label to this issue (#131). I'm not sure if this is a permission issue or if we just need to create some labels (challenge, challenge-appeal).

@bshannon
Copy link
Contributor

bshannon commented Jan 8, 2020

I thought we decided that only exclusions would be allowed in TCK updates that target the current spec version, and that code changes would have to be in a TCK version that targets the next spec version.

Or, code changes targeting the current spec version have to be done in such a way that they do not invalidate any existing Compatibile Implementation that passed the existing TCK.

@scottmarlow
Copy link
Contributor Author

Bill, so to keep with the current TCK process, we could release TCK 8.0.2 with the challenged test excluded. I didn't expect the jakartaee-tck/issues/132 to invalidate any existing Compatible Implementations but I don't really know that for sure.

@scottmarlow
Copy link
Contributor Author

Opened jakartaee-platform/issue#139 for the challenge, closing this one, as I don't think it is needed for the challenge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants