Dependency Injection 2.0 final PR #221

starksm64 · 2020-07-07T04:11:48Z

Signed-off-by: Scott M Stark starksm64@gmail.com

Specification PR template

When creating a specification project release review, create two PRs with the content divided as follows.

Include the following in PR#1:

A directory in the form wombat/x.y where x.y is the release major.minor version, and the directory contains the following.
Specification PDF in the form of wombat-spec-x.y.pdf
Specification HTML in the form of wombat-spec-x.y.html
A specification page named _index.md following the template at:
https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
For a Release Review, a summary that a Compatible Implementation
is complete, passes the TCK, and that the TCK includes sufficient
coverage of the specification. The TCK users guide MUST include
the instructions to run the compatible implementations used to
validate the release. Instructions MAY be by reference.
The URL of the OSSRH staging repository for the api, javadoc:
https://jakarta.oss.sonatype.org/content/groups/staging/jakarta/inject/jakarta.inject-api/2.0.0/
The URL of the staging directory on downloads.eclipse.org for the proposed EFTL TCK binary:
https://download.eclipse.org/ee4j/cdi/inject/2.0/jakarta.inject-tck-2.0.1-bin.zip
The URL of the compatibility certification request issue:
Compatibility certification request for Weld for DI 2.0.0 inject-spec#9
Specification JavaDoc in the wombat/x.y/apidocs directory.

Signed-off-by: Scott M Stark <starksm64@gmail.com>

netlify · 2020-07-07T04:19:24Z

Deploy preview for jakartaee-specifications ready!

Built with commit 66bb9f7

https://deploy-preview-221--jakartaee-specifications.netlify.app

Signed-off-by: Scott M Stark <starksm64@gmail.com>

edbratt

Please be sure to file a compatibility certification request issue in https://github.com/eclipse-ee4j/injection-api/issues and include a link in this discussion (check-box 8). [edit: or injection-spec/issues]
Current Spec. document status in the API repository still states "DRAFT" status. Don't forget to update the formal repository with these changes too.
For the spec document, just an opinion: I would have preferred to see text referring the reader to the JavaDocs for details since there is no detailed description in the specification document, other than the scope statement.
The Readme.md in the TCK refers readers to the injection-tck/issues issue-tracker. I thought the guidance was to ask users to file issues with the api project. Please double check and change if necessary.

edbratt · 2020-07-18T17:22:46Z

I believe this check-list is complete. Thank you!

Spec Review Checklist

Spec PR

_index.md

Link to spec pdf
Link to spec html
Link to apidocs
Link to final TCK download zip file of the form https://download.eclipse.org/jakartaee/{spec}/x.y/*{spec}-tck-x.y.z.zip
Link to API jar file of the form https://search.maven.org/artifact/jakarta.{spec}/jakarta.{spec}-api/x.y.z/jar
Name of and link to at least one Compatible Implementation

javadocs

Footer contains Eclipse copyright and link to license
ESFL license is included, usually as doc-files/speclicense.html
no META-INF directory in PR
javadocs-jar artifact matches apidocs (optional for this release)

Spec PDF

Spec HTML

Same as PDF

TCK zip file

README file (optional for this release)
EFTL license file, preferably named LICENSE.md
User's Guide (or equivalent documentation) - Readme.md
How to test the Compatible Implementation(s) listed in _index.md above with the TCK (may be in UG)

TCK User's Guide (or equivalent documentation)

Software requirements listed
Installation and configuration described
How to run tests
Where to file challenges - Please see review comments

Compatibility certification request

Request follows template
SHA-256 fingerprint matches staged TCK zip file
Request issue has certification label.

TCK results summary (Please re-host the included TCK-summary.md page with the implementation (Weld)). Please include data found here: https://github.com/jakartaee/specification-committee/blob/master/compatibility-certification-request.md

Page is hosted by Compatible Implementation project
Includes all information from certification request
Summary includes number of tests passed, failed, errors
SHA-256 fingerprint matches staged TCK zip file on cert request

Update Jakarta EE API jar (Please provide reference this has been completed)

Update the Jakarta EE API jar by submitting a PR to the jakartaee-api project that updates the version number of your API jar file. (jakartaee-api #70)

Emily-Jiang · 2020-07-19T22:44:19Z

I am wondering whether we need to require the TCK result zip to be updated somewhere as the PR lists Scott's personal mac.

m0mus · 2020-07-20T19:45:37Z

dependency-injection/2.0/_index.md

-title: "Jakarta Dependency Injection 2.0 (milestone)"
-date: 2020-05-18
+title: "Jakarta Dependency Injection 2.0"
+date: 2020-06-7


Should it be 2020-06-07?

m0mus · 2020-07-20T19:47:49Z

dependency-injection/2.0/_index.md

-title: "Jakarta Dependency Injection 2.0 (milestone)"
-date: 2020-05-18
+title: "Jakarta Dependency Injection 2.0"
+date: 2020-06-7
 summary: "Release for Jakarta EE 9"
 ---

 Jakarta Dependency Injection specifies a means for obtaining objects in such a way as to maximize reusability, testability and maintainability compared to traditional approaches such as constructors, factories, and service locators (e.g., JNDI).

 * [Jakarta Dependency Injection 2.0 Release Record]()


Release record is missing. It should be https://projects.eclipse.org/projects/ee4j.cdi/releases/2.0

@starksm64, Not sure why this item was resolved... Since DI is provided as part of the CDI project, then you should reference the CDI Release Record. As it stands today, the rendering of the _index.md file looks like the Release Record is missing (which it is). The easiest fix would be to just reference the CDI release record -- although there is no mention of the DI release in that release record. An easy edit can correct that though. Thanks.

m0mus · 2020-07-20T19:50:07Z

dependency-injection/2.0/_index.md

 * [Jakarta Dependency Injection 2.0 Javadoc](./apidocs)
-* [Jakarta Dependency Injection 2.0 TCK](https://download.eclipse.org/ee4j/cdi/jakarta.inject-tck-2.0.0.RC4-bin.tar.gz) ([sig](https://download.eclipse.org/ee4j/cdi/jakarta.inject-tck-2.0.0.RC4-bin.tar.gz.asc),[sha](),[pub]())
+* [Jakarta Dependency Injection 2.0 TCK](https://download.eclipse.org/ee4j/cdi/inject/2.0/jakarta.inject-tck-2.0.0-bin.tar.gz) ([sig](https://download.eclipse.org/ee4j/cdi/inject/2.0/jakarta.inject-tck-2.0.0-bin.tar.gz.asc),[sha](),[pub]())


sha and pub links are missing.

edbratt · 2020-07-20T21:08:47Z

Please update the details of the Release Record to indicate both CDI and DI are being released. If you'd prefer, you may generate multiple release records, one for CDI and DI. Update the release dates as well.
In the description, please include

a concise description that tells me the key features of the release. In the case of a specification project, the key features are the names and version number of the specifications included in the release.

dependency-injection/2.0/TCK-summary.html

Signed-off-by: Scott M Stark <starksm64@gmail.com>

edbratt

Thank you for completing all items!

edbratt · 2020-08-03T21:45:44Z

Rats. I just looked at the preview and it doesn't list the final TCK location.
The TCK summary and CCR uses:
https://download.eclipse.org/ee4j/cdi/inject/2.0/jakarta.inject-tck-2.0.1-bin.zip
The final TCK download link will be:
https://download.eclipse.org/jakartaee/dependency-injection/2.0/jakarta.inject-tck-2.0.1-bin.zip
The SHA-256 is listed as 7853d02d372838f8300f5a18cfcc23011c9eb9016cf3980bba9442e4b1f8bfc6
Lastly, we need the public key.

edbratt · 2020-08-03T22:52:02Z

Please update the TCK access URLs as follows:

With those changes, this is ready for ballot. Thank you!

Signed-off-by: Scott M Stark <starksm64@gmail.com>

starksm64 · 2020-08-04T21:52:45Z

Done

edbratt · 2020-08-04T23:35:10Z

LGTM! Thank you so much Scott! I've marked it complete. @kwsutter please review/update as needed.

kwsutter

Two minor items need to be resolved and then we should be ready for ballot. Thanks, @starksm64!

dependency-injection/2.0/_index.md

kwsutter · 2020-08-05T01:43:34Z

dependency-injection/2.0/_index.md

-title: "Jakarta Dependency Injection 2.0 (milestone)"
-date: 2020-05-18
+title: "Jakarta Dependency Injection 2.0"
+date: 2020-06-7
 summary: "Release for Jakarta EE 9"
 ---

 Jakarta Dependency Injection specifies a means for obtaining objects in such a way as to maximize reusability, testability and maintainability compared to traditional approaches such as constructors, factories, and service locators (e.g., JNDI).

 * [Jakarta Dependency Injection 2.0 Release Record]()


@starksm64, Not sure why this item was resolved... Since DI is provided as part of the CDI project, then you should reference the CDI Release Record. As it stands today, the rendering of the _index.md file looks like the Release Record is missing (which it is). The easiest fix would be to just reference the CDI release record -- although there is no mention of the DI release in that release record. An easy edit can correct that though. Thanks.

Signed-off-by: Scott M Stark <starksm64@gmail.com>

kwsutter

LGTM! Thanks, @starksm64!

dblevins · 2020-08-05T16:16:00Z

Approved for Ballot. @edbratt will send out the vote when the instructions are found

Signed-off-by: Scott M Stark <starksm64@gmail.com>

kwsutter · 2020-08-06T17:15:53Z

Just removing the complete label since that's inconsistent with our defined use of labels for the review process. We should use the final label to indicate it's past draft and ready for ballot.

jeanouii

See comment bellow

jeanouii · 2020-08-26T16:53:22Z

dependency-injection/2.0/_index.md

  * [Jakarta EE Platform 9 Release Plan](https://eclipse-ee4j.github.io/jakartaee-platform/jakartaee9/JakartaEE9ReleasePlan)
-* [Jakarta Dependency Injection 2.0 Specification Document](./injection-spec-2.0-draft.pdf) (PDF)
-* [Jakarta Dependency Injection 2.0 Specification Document](./injection-spec-2.0-draft.html) (HTML)
+* [Jakarta Dependency Injection 2.0 Specification Document](jakarta-injection-spec-2.0.pdf) (PDF)


As per the template, if directory is wombat, then spec file name should also have wombat

Based on that, I would expect the file name to be jakarta-injection-spec-2.0.pdf (same for html).
Or then use inject only for consistency with TCK filename, and Maven coordinates.

What do you think?

edbratt · 2020-08-28T00:16:28Z

The specification ballot has concluded and this specification has been approved. Please update the ballot tally in _index.md prior to merging:

Representative	Representative for:	Vote
Kenji Kazumura	Fujitsu	1
Dan Bandera, Kevin Sutter	IBM	1
Ed Bratt, Dmitry Kornilov	Oracle	1
Andrew Pielage, Matt Gill	Payara	1
Scott Stark, Mark Little	Red Hat	1
David Blevins, Jean-Louis Monteiro, Cesar Hernandez	Tomitribe	1
Ivar Grimstad	EE4J PMC	1
Marcelo Ancelmo, Martijn Verburg	Participant Members	1
Werner Keil	Committer Members	1
Scott (Congquan) Wang	Enterprise Members	1
	Total	10

Well Done and my thanks to you and your team!

edbratt · 2020-08-28T00:21:55Z

Prepare dependency-injection final PR

6eab242

Signed-off-by: Scott M Stark <starksm64@gmail.com>

starksm64 added draft Work in Progress wave:1 Used for release tracking purposes labels Jul 7, 2020

Fix the api jar url

9871b93

Signed-off-by: Scott M Stark <starksm64@gmail.com>

kwsutter added this to the Jakarta EE 9 milestone Jul 8, 2020

kwsutter requested a review from edbratt July 14, 2020 22:32

edbratt reviewed Jul 18, 2020

View reviewed changes

kwsutter requested a review from m0mus July 20, 2020 00:46

m0mus reviewed Jul 20, 2020

View reviewed changes

Emily-Jiang reviewed Jul 20, 2020

View reviewed changes

dependency-injection/2.0/TCK-summary.html Outdated Show resolved Hide resolved

Replace summary TCK results with link to compatibibility page

f11a7bf

Signed-off-by: Scott M Stark <starksm64@gmail.com>

edbratt approved these changes Aug 3, 2020

View reviewed changes

Update to use the final TCK locations

28752f6

Signed-off-by: Scott M Stark <starksm64@gmail.com>

edbratt added complete All specification tasks for release are complete and removed draft Work in Progress labels Aug 4, 2020

kwsutter requested changes Aug 5, 2020

View reviewed changes

Fix release plan link and date format

c4584e7

Signed-off-by: Scott M Stark <starksm64@gmail.com>

kwsutter self-requested a review August 5, 2020 15:26

kwsutter approved these changes Aug 5, 2020

View reviewed changes

kwsutter added the final Ready for Vote label Aug 5, 2020

dblevins added the ballot Delivered to the Specification Committee for ballot label Aug 5, 2020

update the spec docs names to use jakarta prefix

66bb9f7

Signed-off-by: Scott M Stark <starksm64@gmail.com>

kwsutter removed the complete All specification tasks for release are complete label Aug 6, 2020

dblevins changed the title ~~Prepare dependency-injection final PR~~ Dependency Injection 2.0 final PR Aug 19, 2020

jeanouii reviewed Aug 26, 2020

View reviewed changes

edbratt added the approved The ballot was approved by the Specification Committee label Aug 28, 2020

edbratt merged commit 020cc33 into jakartaee:master Aug 28, 2020

edbratt mentioned this pull request Aug 31, 2020

Updated ballot results and confirmed TCK download specifics #262

Merged

10 tasks

pzygielo mentioned this pull request Sep 15, 2020

Bump jakarta.inject-api eclipse-ee4j/openmq#568

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dependency Injection 2.0 final PR #221

Dependency Injection 2.0 final PR #221

starksm64 commented Jul 7, 2020 •

edited

netlify bot commented Jul 7, 2020 •

edited

edbratt left a comment •

edited

edbratt commented Jul 18, 2020 •

edited

Emily-Jiang commented Jul 19, 2020

m0mus Jul 20, 2020

m0mus Jul 20, 2020

kwsutter Aug 5, 2020

m0mus Jul 20, 2020

edbratt commented Jul 20, 2020

edbratt left a comment

edbratt commented Aug 3, 2020

edbratt commented Aug 3, 2020

starksm64 commented Aug 4, 2020

edbratt commented Aug 4, 2020

kwsutter left a comment

kwsutter Aug 5, 2020

kwsutter left a comment

dblevins commented Aug 5, 2020

kwsutter commented Aug 6, 2020

jeanouii left a comment

jeanouii Aug 26, 2020

edbratt commented Aug 28, 2020

edbratt commented Aug 28, 2020 •

edited

Dependency Injection 2.0 final PR #221

Dependency Injection 2.0 final PR #221

Conversation

starksm64 commented Jul 7, 2020 • edited

Specification PR template

netlify bot commented Jul 7, 2020 • edited

edbratt left a comment • edited

Choose a reason for hiding this comment

edbratt commented Jul 18, 2020 • edited

Spec Review Checklist

Emily-Jiang commented Jul 19, 2020

m0mus Jul 20, 2020

Choose a reason for hiding this comment

m0mus Jul 20, 2020

Choose a reason for hiding this comment

kwsutter Aug 5, 2020

Choose a reason for hiding this comment

m0mus Jul 20, 2020

Choose a reason for hiding this comment

edbratt commented Jul 20, 2020

edbratt left a comment

Choose a reason for hiding this comment

edbratt commented Aug 3, 2020

edbratt commented Aug 3, 2020

starksm64 commented Aug 4, 2020

edbratt commented Aug 4, 2020

kwsutter left a comment

Choose a reason for hiding this comment

kwsutter Aug 5, 2020

Choose a reason for hiding this comment

kwsutter left a comment

Choose a reason for hiding this comment

dblevins commented Aug 5, 2020

kwsutter commented Aug 6, 2020

jeanouii left a comment

Choose a reason for hiding this comment

jeanouii Aug 26, 2020

Choose a reason for hiding this comment

edbratt commented Aug 28, 2020

edbratt commented Aug 28, 2020 • edited

starksm64 commented Jul 7, 2020 •

edited

netlify bot commented Jul 7, 2020 •

edited

edbratt left a comment •

edited

edbratt commented Jul 18, 2020 •

edited

edbratt commented Aug 28, 2020 •

edited