-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jakarta XML Binding 4.0 Plan Review #357
Conversation
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
✔️ Deploy Preview for jakartaee-specifications ready! 🔨 Explore the source changes: fde623a 🔍 Inspect the deploy log: https://app.netlify.com/sites/jakartaee-specifications/deploys/60b90dfe6f6dd60008f806f8 😎 Browse the preview: https://deploy-preview-357--jakartaee-specifications.netlify.app |
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
LGTM |
The goal of this release is to: | ||
|
||
* provide features requested by the community | ||
* implement requirements by other specification included in Jakarta EE 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see an explicit statement regarding the required major version update. I know we've discussed this on other Plan Reviews, but it would be good to explain the specific reason in this JAXB update. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kwsutter Dropping support for JAXB 1 related APIs/functionality (ie validation) as well as dropping explicit dependency on JavaBeans Framework are both removals, thus backward incompatible changes requiring major version change - both are explicitly mentioned (and both also fall under requirements from other specs, in this case xml-ws). Or do youmean sth else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukasj Those are the type of changes I was referring to. I was just looking for something more explicit in the text of the release plans to indicate that. For example, something along these lines:
- drop explicit dependency on JavaBeans (Has transitive relationship to any dependent specifications. Removal of JavaBeans is a breaking API change.)
- editorial updates, clarifications and removal of JAXB 1 from the specification (May have transitive relationship to any dependent specifications. Removal of JAXB 1 is a breaking API change.)
Just something to allow the casual reader to understand why a major version upgrade was necessary. I know it's very natural for you and others more intimate with JAXB, but for others, it helps identify the reasons for the major version update. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it allowed to change the PR while the ballot is in progress? since it seems to be required to explicitly list bkwd incompatibilities now in the plan, does it mean that updating the same entry in the release record - probably before release review - is not/won't be required to avoid duplications or is the expectation that both should be kept in sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, you are just further clarifying your intent of the Release Plan. You're not modifying what was going to be included. You are just explaining that these proposed changes are the reason behind the major version update. That is an okay update to make in the middle of a ballot. Thanks.
Prior to merge, could I ask you to update the XML Binding 2.3 _index.md file to remove "Specification" from the title field meta-data? This breaks the sort order for the mid-level page and puts the v2.3 page at the bottom of the list. |
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is there anything I need to do here to move this forward? |
* add minutes for April 27 call Signed-off-by: Ivar Grimstad <ivar.grimstad@eclipse-foundation.org> * Add minutes for May 4 call Signed-off-by: Ivar Grimstad <ivar.grimstad@eclipse-foundation.org>
Signed-off-by: Lukas Jungmann lukas.jungmann@oracle.com
Plan Review PR template
When creating a specification project plan review, create PRs with the content defined as follows.
Include the following in the PR:
https://projects.eclipse.org/projects/ee4j.jaxb/releases/4.0