Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta XML Binding 4.0 Plan Review #357

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Conversation

lukasj
Copy link
Contributor

@lukasj lukasj commented Apr 14, 2021

Signed-off-by: Lukas Jungmann lukas.jungmann@oracle.com

Plan Review PR template

When creating a specification project plan review, create PRs with the content defined as follows.

Include the following in the PR:

  • A directory in the form wombat/x.y where x.y is the release major.minor version.
  • An index page wombat/x.y/_index.md following template
  • Title should be on the form "Jakarta Wombat X.Y (under development)"
  • Includes a plan for the release. Usually, a couple of statements is enough. Otherwise, a link to a document describing the release.
  • N/A - Includes a detailed description of any backward incompatibility (Mark with N/A and check if none)
  • N/A - Declares optional features if there are any (Mark with N/A and check if none)
  • Includes minimum Java SE version
  • N/A - Describe any updates or required changes including splitting out the TCK (Mark with N/A and check if not planned)
  • Link to updated release record
    https://projects.eclipse.org/projects/ee4j.jaxb/releases/4.0

Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@netlify
Copy link

netlify bot commented Apr 14, 2021

✔️ Deploy Preview for jakartaee-specifications ready!

🔨 Explore the source changes: fde623a

🔍 Inspect the deploy log: https://app.netlify.com/sites/jakartaee-specifications/deploys/60b90dfe6f6dd60008f806f8

😎 Browse the preview: https://deploy-preview-357--jakartaee-specifications.netlify.app

@ivargrimstad ivargrimstad added the plan review Use this label on PRs that are filed for plan reviews label Apr 14, 2021
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@marceloancelmo
Copy link
Contributor

LGTM
I will initiate the ballot soon

Jakarta EE 10 Plan Reviews automation moved this from In progress to Reviewer approved (start ballot) May 31, 2021
@marceloancelmo marceloancelmo added the ballot Delivered to the Specification Committee for ballot label May 31, 2021
The goal of this release is to:

* provide features requested by the community
* implement requirements by other specification included in Jakarta EE 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see an explicit statement regarding the required major version update. I know we've discussed this on other Plan Reviews, but it would be good to explain the specific reason in this JAXB update. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kwsutter Dropping support for JAXB 1 related APIs/functionality (ie validation) as well as dropping explicit dependency on JavaBeans Framework are both removals, thus backward incompatible changes requiring major version change - both are explicitly mentioned (and both also fall under requirements from other specs, in this case xml-ws). Or do youmean sth else?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukasj Those are the type of changes I was referring to. I was just looking for something more explicit in the text of the release plans to indicate that. For example, something along these lines:

  • drop explicit dependency on JavaBeans (Has transitive relationship to any dependent specifications. Removal of JavaBeans is a breaking API change.)
  • editorial updates, clarifications and removal of JAXB 1 from the specification (May have transitive relationship to any dependent specifications. Removal of JAXB 1 is a breaking API change.)

Just something to allow the casual reader to understand why a major version upgrade was necessary. I know it's very natural for you and others more intimate with JAXB, but for others, it helps identify the reasons for the major version update. Thanks!

Copy link
Contributor Author

@lukasj lukasj Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it allowed to change the PR while the ballot is in progress? since it seems to be required to explicitly list bkwd incompatibilities now in the plan, does it mean that updating the same entry in the release record - probably before release review - is not/won't be required to avoid duplications or is the expectation that both should be kept in sync?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, you are just further clarifying your intent of the Release Plan. You're not modifying what was going to be included. You are just explaining that these proposed changes are the reason behind the major version update. That is an okay update to make in the middle of a ballot. Thanks.

@edbratt
Copy link
Contributor

edbratt commented Jun 3, 2021

Prior to merge, could I ask you to update the XML Binding 2.3 _index.md file to remove "Specification" from the title field meta-data? This breaks the sort order for the mid-level page and puts the v2.3 page at the bottom of the list.

Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Copy link

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj
Copy link
Contributor Author

lukasj commented Jul 13, 2021

Is there anything I need to do here to move this forward?

@kwsutter kwsutter self-requested a review July 13, 2021 20:59
@kwsutter kwsutter merged commit f580efc into jakartaee:master Jul 13, 2021
Jakarta EE 10 Plan Reviews automation moved this from Reviewer approved (start ballot) to Done Jul 13, 2021
@lukasj lukasj deleted the xmlb40 branch July 13, 2021 21:13
@kwsutter kwsutter added approved The ballot was approved by the Specification Committee and removed ballot Delivered to the Specification Committee for ballot labels Aug 18, 2021
starksm64 pushed a commit to starksm64/specifications that referenced this pull request Dec 20, 2021
* add minutes for April 27 call

Signed-off-by: Ivar Grimstad <ivar.grimstad@eclipse-foundation.org>

* Add minutes for May 4 call

Signed-off-by: Ivar Grimstad <ivar.grimstad@eclipse-foundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The ballot was approved by the Specification Committee plan review Use this label on PRs that are filed for plan reviews
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants