Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta JSP 3.1 Plan Review #366

Merged
merged 4 commits into from Jun 24, 2021
Merged

Conversation

markt-asf
Copy link
Contributor

Plan Review PR template

When creating a specification project plan review, create PRs with the content defined as follows.

Include the following in the PR:

  • A directory in the form wombat/x.y where x.y is the release major.minor version.
  • An index page wombat/x.y/_index.md following template
  • Title should be on the form "Jakarta Wombat X.Y (under development)"
  • Includes a plan for the release. Usually, a couple of statements is enough. Otherwise, a link to a document describing the release.
  • Includes a detailed description of any backward incompatibility (Mark with N/A and check if none)
  • Declares optional features if there are any (Mark with N/A and check if none)
  • Includes minimum Java SE version
  • Describe any updates or required changes including splitting out the TCK (Mark with N/A and check if not planned)
  • Link to updated release record

@netlify
Copy link

netlify bot commented Apr 15, 2021

✔️ Deploy Preview for jakartaee-specifications ready!

🔨 Explore the source changes: b32ed84

🔍 Inspect the deploy log: https://app.netlify.com/sites/jakartaee-specifications/deploys/60d42e551ba5460007517c9c

😎 Browse the preview: https://deploy-preview-366--jakartaee-specifications.netlify.app

@ivargrimstad ivargrimstad added the plan review Use this label on PRs that are filed for plan reviews label Apr 15, 2021
@kwsutter kwsutter added this to In progress in Jakarta EE 10 Plan Reviews May 5, 2021
@kwsutter kwsutter requested a review from keilw May 5, 2021 18:44
Copy link
Member

@keilw keilw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markt-asf The readme file has both Release Review and Plan Review result table, shouldn't they be commented out for now, and just the plan one, at least that's how Authorization 2.1 or Authentication 3.0 (see #356) looked like.

Jakarta EE 10 Plan Reviews automation moved this from In progress to Review in progress Jun 15, 2021
@keilw
Copy link
Member

keilw commented Jun 15, 2021

@kwsutter Or is there a certain freedom to leave those and e.g. fix it with the ballot result? If it's OK like that I would start the ballot tomorrow.

Jakarta EE 10 Plan Reviews automation moved this from Review in progress to Reviewer approved (start ballot) Jun 16, 2021
@keilw keilw added the ballot Delivered to the Specification Committee for ballot label Jun 16, 2021
@keilw
Copy link
Member

keilw commented Jun 16, 2021

I am starting the ballot but I noticed something strange under https://deploy-preview-366--jakartaee-specifications.netlify.app, the page looks weird, @markt-asf could you have a look at that please, I don't think it directly affects this PR so ballot seems OK but it would be nice to correct the formatting of the preview content.
@kwsutter, @ivargrimstad is it possible that preview was affected by other bad or malformed pages around a month ago?

Copy link
Contributor

@kwsutter kwsutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @markt-asf! Just a nit update -- should clean this up before we merge.

pages/3.1/_index.md Outdated Show resolved Hide resolved
@kwsutter
Copy link
Contributor

kwsutter commented Jun 23, 2021

I am starting the ballot but I noticed something strange under https://deploy-preview-366--jakartaee-specifications.netlify.app, the page looks weird, @markt-asf could you have a look at that please, I don't think it directly affects this PR so ballot seems OK but it would be nice to correct the formatting of the preview content.
@kwsutter, @ivargrimstad is it possible that preview was affected by other bad or malformed pages around a month ago?

I agree that the Preview is messed up. Something must have happened during this pre-deploy step. I was still able to traverse the pages and find the material. Although it's not formatted correctly, the data looks good. Looks like just a hiccup with the deployment processing...

@keilw keilw added the approved The ballot was approved by the Specification Committee label Jun 24, 2021
@keilw keilw merged commit 8e01033 into jakartaee:master Jun 24, 2021
Jakarta EE 10 Plan Reviews automation moved this from Reviewer approved (start ballot) to Done Jun 24, 2021
@keilw
Copy link
Member

keilw commented Jun 24, 2021

@kwsutter @ivargrimstad Merged, is it better to sort out the preview now, or could I still push/merge the ballot result first?

@markt-asf markt-asf deleted the jsp-3.1.0-plan branch April 25, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The ballot was approved by the Specification Committee ballot Delivered to the Specification Committee for ballot plan review Use this label on PRs that are filed for plan reviews
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants