New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jakarta JSP 3.1 Plan Review #366
Conversation
✔️ Deploy Preview for jakartaee-specifications ready! 🔨 Explore the source changes: b32ed84 🔍 Inspect the deploy log: https://app.netlify.com/sites/jakartaee-specifications/deploys/60d42e551ba5460007517c9c 😎 Browse the preview: https://deploy-preview-366--jakartaee-specifications.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markt-asf The readme file has both Release Review and Plan Review result table, shouldn't they be commented out for now, and just the plan one, at least that's how Authorization 2.1 or Authentication 3.0 (see #356) looked like.
@kwsutter Or is there a certain freedom to leave those and e.g. fix it with the ballot result? If it's OK like that I would start the ballot tomorrow. |
I am starting the ballot but I noticed something strange under https://deploy-preview-366--jakartaee-specifications.netlify.app, the page looks weird, @markt-asf could you have a look at that please, I don't think it directly affects this PR so ballot seems OK but it would be nice to correct the formatting of the preview content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @markt-asf! Just a nit update -- should clean this up before we merge.
I agree that the Preview is messed up. Something must have happened during this pre-deploy step. I was still able to traverse the pages and find the material. Although it's not formatted correctly, the data looks good. Looks like just a hiccup with the deployment processing... |
@kwsutter @ivargrimstad Merged, is it better to sort out the preview now, or could I still push/merge the ballot result first? |
Plan Review PR template
When creating a specification project plan review, create PRs with the content defined as follows.
Include the following in the PR: