Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta SOAP with Attachments 1.4 #46

Merged
merged 10 commits into from Feb 20, 2020
Merged

Jakarta SOAP with Attachments 1.4 #46

merged 10 commits into from Feb 20, 2020

Conversation

lukasj
Copy link
Contributor

@lukasj lukasj commented Jul 22, 2019

Signed-off-by: Lukas Jungmann lukas.jungmann@oracle.com

PR#1:

Include the following in PR#2:

  • Specification JavaDoc in the wombat/x.y/apidocs directory.

@dblevins dblevins added the draft Work in Progress label Jul 24, 2019
@dblevins dblevins added the javase Former Java SE specification not required for Jakarta EE 8 label Aug 23, 2019
@netlify
Copy link

netlify bot commented Sep 18, 2019

Deploy preview for jakartaee-specifications ready!

Built with commit d0fab1a

https://deploy-preview-46--jakartaee-specifications.netlify.com

@lukasj
Copy link
Contributor Author

lukasj commented Sep 24, 2019

this one should be ready too; the only thing is that the compatible implementation has no name, so I used "Jakarta SOAP with Attachments Implementation"

@kwsutter
Copy link
Contributor

Just putting a "hold" tag on this issue since it hasn't been decided whether the jax-ws specs will be part of Jakarta EE 9 or not...

@bshannon
Copy link
Contributor

Just putting a "hold" tag on this issue since it hasn't been decided whether the jax-ws specs will be part of Jakarta EE 9 or not...

We can approve this spec whether it's included in Jakarta EE 9 or not, right?
Approving this (and other related) spec allows it to be used in standalone
implementations and Jakarta EE implementations independently of the JCP.

@kwsutter kwsutter removed the hold label Jan 8, 2020
Copy link
Contributor

@kwsutter kwsutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj
Copy link
Contributor Author

lukasj commented Jan 25, 2020

TODOs: upload refreshed binaries, fix TCK URL

@lukasj
Copy link
Contributor Author

lukasj commented Jan 27, 2020

binaries were refreshed

Copy link
Contributor

@kwsutter kwsutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, but the names of the Specs should be updated to be consistent with the rest of Jakarta EE.

soap-attachments/1.4/_index.md Outdated Show resolved Hide resolved
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@kwsutter kwsutter added ballot Delivered to the Specification Committee for ballot approved The ballot was approved by the Specification Committee and removed draft Work in Progress ballot Delivered to the Specification Committee for ballot labels Feb 20, 2020
Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
@kwsutter kwsutter merged commit f557376 into jakartaee:master Feb 20, 2020
@kwsutter kwsutter added ballot Delivered to the Specification Committee for ballot final Ready for Vote labels Feb 20, 2020
@kwsutter
Copy link
Contributor

kwsutter commented Feb 20, 2020

  • The designated specification committee representative adds this final checklist to the main PR.
  • The specification committee representative merges the specification and apidocs PRs.
  • The designated specification committee representative calculates the staged EFTL TCK signature and promotes it to the committee download area
    using the https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/ job.
  • The specification project member who created the staging release promotes the specification api jars to maven central. An example release job script can be found here https://wiki.eclipse.org/MavenReleaseScript.
  • The EMO updates the specification page with the ballot results.
    This list goes on the committed spec index page.
  • The specification project team should go through the merged spec website page to verify all the links are valid.
  • The specification project team should approve the compatibility request.
  • The compatible implementation project/vendor MUST send an email tck@eclipse.org for approval of the compatible implementation for trademark usage.
  • The specification project team should merge any final release branch as appropriate for the branch management for the project.

@lukasj lukasj deleted the saaj branch February 27, 2020 15:31
@lukasj
Copy link
Contributor Author

lukasj commented Mar 5, 2020

@kwsutter unchecked items were done

@kwsutter
Copy link
Contributor

kwsutter commented Mar 5, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The ballot was approved by the Specification Committee ballot Delivered to the Specification Committee for ballot final Ready for Vote javase Former Java SE specification not required for Jakarta EE 8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants