Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta Web Services Metadata 2.1 #48

Merged
merged 9 commits into from Feb 20, 2020
Merged

Jakarta Web Services Metadata 2.1 #48

merged 9 commits into from Feb 20, 2020

Conversation

lukasj
Copy link
Contributor

@lukasj lukasj commented Jul 22, 2019

Signed-off-by: Lukas Jungmann lukas.jungmann@oracle.com

PR#1:

Include the following in PR#2:

  • Specification JavaDoc in the wombat/x.y/apidocs directory.

@dblevins dblevins added the draft Work in Progress label Jul 24, 2019
@dblevins
Copy link
Contributor

It appears the staging repo has been deleted:

@lukasj
Copy link
Contributor Author

lukasj commented Aug 23, 2019

correct, the version should be 2.1.0 (since the last version on the JCP is 2.1, the spec should say 2.1 instead of 1.1). As this is not critical for the upcoming release, I'm going to update this (and fix all other more or less related PRs) next week.

@dblevins dblevins added the javase Former Java SE specification not required for Jakarta EE 8 label Aug 23, 2019
@netlify
Copy link

netlify bot commented Sep 10, 2019

Deploy preview for jakartaee-specifications ready!

Built with commit a71e7c6

https://deploy-preview-48--jakartaee-specifications.netlify.com

@lukasj lukasj changed the title Jakarta Web Services Metadata 1.1 Jakarta Web Services Metadata 2.1 Oct 2, 2019
@kwsutter kwsutter added the hold label Nov 20, 2019
@kwsutter
Copy link
Contributor

Just putting a "hold" tag on this issue since it hasn't been decided whether the jax-ws specs will be part of Jakarta EE 9 or not...

@lukasj
Copy link
Contributor Author

lukasj commented Nov 20, 2019

well, this API in particular is supposed to be part of Java EE8, thus also Jakarta EE8 but for some reason, likely intentionally as the same version exists in Java SE 8, has not been included in the initial release. See ie Java EE 8 spec, table EE.6-1 (pages 159-160), chapter EE.6.27 (page 189) or chapter EE.9.7 (pages 234-235) or equivalents in Jakarta EE 8 spec document; I've found no sentence in the existing specs saying that this can come from Java SE but as long as the API as such is available, it is perhaps fine.

Also note that all these APIs were removed from Java SE 11, so whatever gets decided regarding required Java SE versions has impact on either pruning/adding this and related APIs.

@kwsutter
Copy link
Contributor

Definitely agree with your arguments, @lukasj. If you feel that any of these Specs have to be part of Jakarta EE 9, then please join in the discussion on the Platform dev mailing list. At this point, none of the three APIs related to XML Web Services are being requested to be added back in. Although jax-ws is getting some backing...
https://accounts.eclipse.org/mailing-list/jakartaee-platform-dev
https://www.eclipse.org/lists/jakartaee-platform-dev/msg00839.html
https://www.eclipse.org/lists/jakartaee-platform-dev/msg00838.html

Thanks!

@kwsutter kwsutter removed the hold label Jan 8, 2020
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj
Copy link
Contributor Author

lukasj commented Jan 25, 2020

TODOs: upload refreshed binaries, fix TCK URL

@lukasj
Copy link
Contributor Author

lukasj commented Jan 27, 2020

binaries were refreshed

Copy link
Contributor

@kwsutter kwsutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve just to make progress. But, if you have the cycles, it would probably be good to rename your specs to be consistent with the rest of the specs generated for Jakarta EE.

web-services-metadata/2.1/_index.md Outdated Show resolved Hide resolved
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@kwsutter kwsutter added ballot Delivered to the Specification Committee for ballot approved The ballot was approved by the Specification Committee and removed draft Work in Progress ballot Delivered to the Specification Committee for ballot labels Feb 20, 2020
Signed-off-by: Kevin Sutter <kwsutter@gmail.com>
@kwsutter kwsutter merged commit ed80447 into jakartaee:master Feb 20, 2020
@kwsutter kwsutter added ballot Delivered to the Specification Committee for ballot final Ready for Vote labels Feb 20, 2020
@kwsutter
Copy link
Contributor

kwsutter commented Feb 20, 2020

  • The designated specification committee representative adds this final checklist to the main PR.
  • The specification committee representative merges the specification and apidocs PRs.
  • The designated specification committee representative calculates the staged EFTL TCK signature and promotes it to the committee download area
    using the https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/ job.
  • The specification project member who created the staging release promotes the specification api jars to maven central. An example release job script can be found here https://wiki.eclipse.org/MavenReleaseScript.
  • The EMO updates the specification page with the ballot results.
    This list goes on the committed spec index page.
  • The specification project team should go through the merged spec website page to verify all the links are valid.
  • The specification project team should approve the compatibility request.
  • The compatible implementation project/vendor MUST send an email tck@eclipse.org for approval of the compatible implementation for trademark usage.
  • The specification project team should merge any final release branch as appropriate for the branch management for the project.

@lukasj lukasj deleted the jws branch February 27, 2020 15:31
@lukasj
Copy link
Contributor Author

lukasj commented Mar 5, 2020

@kwsutter unchecked items were done

@kwsutter
Copy link
Contributor

kwsutter commented Mar 5, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The ballot was approved by the Specification Committee ballot Delivered to the Specification Committee for ballot final Ready for Vote javase Former Java SE specification not required for Jakarta EE 8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants