Jakarta Interceptors 1.2

[arjantijms]

Signed-off-by: arjantijms arjan.tijms@gmail.com

Specification PR template

When creating a specification project release review, create two PRs with the content divided as follows.

Include the following in PR#1:

• A directory in the form wombat/x.y where x.y is the release major.minor version, and the directory contains the following.
• Specification PDF in the form of wombat_x.y.pdf
• Specification HTML in the form of wombat_x.y.html
• A specification page named _index.md following the template at:
  https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
• For a Release Review, a summary that a Compatible Implementation
  is complete, passes the TCK, and that the TCK includes sufficient
  coverage of the specification. The TCK users guide MUST include
  the instructions to run the compatible implementations used to
  validate the release. Instructions MAY be by reference.
• The URL of the OSSRH staging repository for the api, javadoc:
  https://oss.sonatype.org/content/repositories/staging/jakarta/interceptor/jakarta.interceptor-api/1.2.5/
• The URL of the staging directory on downloads.eclipse.org for the proposed EFTL TCK binary:
  http://download.eclipse.org/ee4j/jakartaee-tck/jakartaee8-eftl/promoted/eclipse-jakartaeetck-8.0.0.zip)
• The URL of the compatibility certification request issue:
  Compatibility certification request for EE4J implementation of Jakarta Interceptors interceptors#49

[dblevins]

Spec status is Draft, but should be Final or Final Release.

[starksm64]

Spec Review Checklist

1. Spec PR

• PR uses template
• Directory of form {spec}/x.y
• PDF of form {spec}-spec-x.y.pdf ("-spec" preferred but not required)
• HTML of form {spec}-spec-x.y.html ("-spec" preferred but not required)
• Index page {spec}/x.y/_index.md following template
• Index page {spec}/_index.md following template
• No other files (e.g., no jakarta_ee_logo_schooner_color_stacked_default.png)
• Staging repository link of the form https://oss.sonatype.org/conte/repositories/staging/jakarta/{spec}/jakarta-{spec}-api/x.y.z/
• EFTL TCK link of the form http://download.eclipse.org/.../+.zip
• Compatibility certification link of the form https://github.com/eclipse-ee4j/{project}/#{issue}
• Second PR for just apidocs

2. _index.md

• Link to spec pdf
• Link to spec html
• Link to apidocs
• Link to final TCK download zip file of the form https://download.eclipse.org/jakartaee/{spec}/x.y/*{spec}-tck-x.y.z.zip
• Link to API jar file of the form https://search.maven.org/artifact/jakarta.{spec}/jakarta.{spec}-api/x.y.z/jar
• Name of and link to at least one Compatible Implementation

3. javadocs

• Footer contains Eclipse copyright and link to license
• ESFL license is included, usually as doc-files/speclicense.html
• no META-INF directory in PR

4. Spec PDF

• Correct spec title
• Version number of the form x.y, not x.y.z
• Correct Eclipse copyright line
• No DRAFT or SNAPSHOT

5. Spec HTML

• Same as PDF

6. TCK zip file

• README file (optional for this release)
• EFTL license file, preferably named LICENSE.md
• User's Guide (or equivalent documentation)
• How to test the Compatible Implementation(s) listed in _index.md above with the TCK (may be in UG)

7. TCK User's Guide (or equivalent documentation)

• Software requirements listed
• Installation and configuration described
• How to run tests
• Where to file challenges

8. Compatibility certification request

• Request follows template
• SHA-256 fingerprint matches staged TCK zip file
• Request issue has certification label.

9. TCK results summary

• Page is hosted by Compatible Implementation project
• Includes all information from certification request
• Summary includes number of tests passed, failed, errors

[kwsutter]

Comments...

• The link for the TCK in the _index.md file should be of the form https://download.eclipse.org/jakartaee/<project>/<major>.<minor>/<zip-file-name>

• If you are using the Glassfish CI and TCK for the testing, should you just be referencing the Glassfish CR instead of creating a CR for Interceptors? Compatibility certification request for Eclipse GlassFish 5.1 for Full Platform platform#99

[kwsutter]

A couple of changes. Main question is about whether you should just be piggybacking on the Glassfish TCK results and CR.

[arjantijms]

The link for the TCK in the _index.md file should be of the form
https://download.eclipse.org/jakartaee//./

If you mean for Interceptors; that one doesn't exist. There is no Interceptors TCK :(

[arjantijms]

If you are using the Glassfish CI and TCK for the testing, should you just be referencing the Glassfish CR instead of creating a CR for Interceptors? jakartaee/platform#99

That's a good question. Hmmm, I'm not sure what the answer is. @bshannon ? @dblevins ?

[bshannon]

Yes, you should just point to the GlassFish CR and the platform TCK.

[arjantijms]

@bshannon okay, thanks for the confirmation.

[bshannon]

@arjantijms This PR should refer to a certification request in the interceptor-api project.

[arjantijms]

@arjantijms This PR should refer to a certification request in the interceptor-api project.

I updated it once again to the existing CR in the interceptor-api project, see jakartaee/interceptors#49

[bshannon]

Marking this final.

[dblevins]

• On ballot completion

• The designated specification committee representative adds this final checklist to the main PR.
• The specification committee representative merges the specification PRs.
• The designated specification committee representative calculates the staged EFTL TCK signature and promotes it to the committee download area
  using the https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/ job.
• The specification project member who created the staging release promotes the specification api jars to maven central. An example release job script can be found here https://wiki.eclipse.org/MavenReleaseScript.
• The EMO updates the specification page with the ballot results.
  This list goes on the committed spec index page.
• The specification project team should go through the merged spec website page to verify all the links are valid.
• The specification project team should approve the compatibility request.
• The compatible implementation project/vendor MUST send an email tck@eclipse.org for approval of the compatible implementation for trademark usage.
• The specification project team should merge any final release branch as appropriate for the branch management for the project.

[arjantijms]

• APi jars released: https://repo1.maven.org/maven2/jakarta/interceptor/jakarta.interceptor-api/1.2.5/
• Mail sent
• Links checked
• Release branch merged: Merge final release branch for 1.2.5 interceptors#50