Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta MVC 2.1 #534

Merged
merged 10 commits into from
Oct 6, 2022
Merged

Jakarta MVC 2.1 #534

merged 10 commits into from
Oct 6, 2022

Conversation

ivargrimstad
Copy link
Member

@ivargrimstad ivargrimstad commented Sep 5, 2022

Specification PR template

When creating a specification project release review, create PRs with the content defined as follows.

Include the following in the PR:

Note: If any item does not apply, check it and mark N/A below it.

@ivargrimstad ivargrimstad changed the title Release Jakarta MVC 2.1 Jakarta MVC 2.1 Sep 5, 2022
@netlify
Copy link

netlify bot commented Sep 5, 2022

Deploy Preview for jakartaee-specifications ready!

Name Link
🔨 Latest commit 77e1c48
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee-specifications/deploys/6316e4a97ed34d000a9d880c
😎 Deploy Preview https://deploy-preview-534--jakartaee-specifications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ivargrimstad ivargrimstad marked this pull request as ready for review September 6, 2022 06:14
@ivargrimstad ivargrimstad added the release review Use this label on PRs that are filed for release review label Sep 6, 2022
@keilw keilw added the ballot Delivered to the Specification Committee for ballot label Sep 16, 2022
@@ -1,23 +1,59 @@
---
title: "Jakarta MVC 2.1 (under development)"
title: "Jakarta MVC 2.1"
date: 2021-04-15
summary: "Release for Jakarta EE 10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it relates Jakarta EE 10 release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. What we meant by the comment is that it requires EE 10.
I can change the text to "Release that supports Jakarta EE 10" after the review.

@Emily-Jiang
Copy link
Contributor

The copyright on the javadoc says 2017, 2020, which should be 2017, 2022.

@ivargrimstad
Copy link
Member Author

The copyright on the javadoc says 2017, 2020, which should be 2017, 2022.

We'll fix that in a service release

@ivargrimstad
Copy link
Member Author

Hi @keilw I will close this PR now. Please submit a new with the ballot results.

@ivargrimstad ivargrimstad merged commit cd08c18 into jakartaee:master Oct 6, 2022
@keilw keilw added the approved The ballot was approved by the Specification Committee label Oct 6, 2022
@ivargrimstad ivargrimstad deleted the mvc-2.1 branch August 2, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The ballot was approved by the Specification Committee ballot Delivered to the Specification Committee for ballot release review Use this label on PRs that are filed for release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants