New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jakarta CDI 4.1 final release #704
Conversation
Signed-off-by: Scott M Stark <starksm64@gmail.com>
✅ Deploy Preview for jakartaee-specifications ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Scott M Stark <starksm64@gmail.com>
This should be ready |
@starksm64 I added a comment on the CCR as it needs to be executed by both Java 17 and Java 21. Once it is ready, I can start the ballot. |
@Emily-Jiang The SE 21 runs have been added |
@starksm64 I reviewed the PR and found the following issues, which need to be resolved: See here
d. Under |
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Done
…On Tue, Mar 5, 2024 at 7:58 AM Emily Jiang ***@***.***> wrote:
@starksm64 <https://github.com/starksm64> I reviewed the PR and found the
following issues, which need to be resolved:
1. The spec doc status still shows Draft. Therefore, the license was
wrong as well. You need to restage the release.
2. On the CDI 4.1 page
<https://deploy-preview-704--jakartaee-specifications.netlify.app/specifications/cdi/4.1/>
,
a. you need to update the Minimum Java SE Version to Java SE 11 as
currently it shows Java SE 17 or higher.
b. At the moment, only cdi main jar was listed. Do we also need to
list the lang model and cdi.el jar as well. If not, where would be listed.
c. Do we need to say CDI 4.1 beans.xml instead of saying CDI 4.0
beans.xml.
Schemas
[XML Schema for the CDI 4.0 beans.xml deployment](https://jakarta.ee/xml/ns/jakartaee/beans_4_0.xsd)
No changes currently planed for the schema
d. Under Compatible Implementations, please remove tbd.
—
Reply to this email directly, view it on GitHub
<#704 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACRDMWNI3YFJBOHUTOL5PTYWXFSDAVCNFSM6AAAAABEBHMQZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZYHAZTGOBWHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@starksm64 there are more changes to be done apart from removing |
Signed-off-by: Scott M Stark <starksm64@gmail.com>
- Add lang-model and el-api artifact links Signed-off-by: Scott M Stark <starksm64@gmail.com>
- jakarta.enterprise.cdi-api - jakarta.enterprise.cdi-el-api - jakarta.enterprise.lang-model Signed-off-by: Scott M Stark <starksm64@gmail.com>
@Emily-Jiang There should be nothing left to do on this |
|
Specification PR template
When creating a specification project release review, create PRs with the content defined as follows.
Include the following in the PR:
https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
Instructions MAY be by reference.
https://jakarta.oss.sonatype.org/content/groups/staging/jakarta/enterprise/jakarta.enterprise.cdi-api/4.1.0/
https://download.eclipse.org/ee4j/cdi/4.1/
Weld 6.0.0.Beta1
If desired, an optional second PR can be created to contain just the JavaDoc in the
apidocs
directory.Note: If any item does not apply, check it and mark N/A below it.