New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jakarta RESTful Web Services: API docs #8
Jakarta RESTful Web Services: API docs #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a serious issue, but META-INF/MANIFEST.MF isn't needed here.
I see a reference to the license on the index page but it's missing from the footer of every page.
c55d157
to
d234ee6
Compare
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
d234ee6
to
45421fc
Compare
Javadocs updated. |
I noted that the Javadocs seem to have "@SInCE 2.0" and I was expecting these to be "@SInCE JAX-RS 2.0" or similar based on https://www.eclipse.org/lists/ee4j-pmc/msg02056.html but perhaps as the JAX-RS element was not removed for this release (I assume, based on e.g. this file) then it might not be required to actively add this clarification? |
Frankly, we have made most of the API changes before some of those discussions started (or settled). Moreover, we went through the process of eliminating all the "JAX-RS" instances in our docs, so adding those seemed odd at the time; however, if the consensus is to use old acronyms with
Can you elaborate this? I'm not sure which part of that file you're referring to. |
Fixing the @SInCE entries is not critical for this release. |
Not sure if this is a showstopper, but there are some "Java EE" references we might want to convert:
|
I've changed it to Jakarta EE. |
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
fd5db32
to
a4f205a
Compare
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I'm removing the Draft label.
Obviously this still needs to wait for PR #7.
This spec is due for review and promotion to vote August 16th. Can you review this checklist and ensure all requirements are met: |
We are working on it and making progress. We should be done in time. |
Signed-off-by: Santiago Pericas-Geertsen santiago.pericasgeertsen@oracle.com
Specification PR template
Include the following:
https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
a Compatible Implementation and TCK, to ensure that the spec is
implementable and testable.
is complete, passes the TCK, and that the TCK includes sufficient
coverage of the specification. The TCK users guide MUST include
the instructions to run the compatible implementations used to
validate the release. Instructions MAY be by reference.