Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta RESTful Web Services: API docs #8

Merged
merged 3 commits into from Sep 3, 2019

Conversation

spericas
Copy link
Contributor

Signed-off-by: Santiago Pericas-Geertsen santiago.pericasgeertsen@oracle.com

Specification PR template

Include the following:

  • A directory in the form wombat/x.y containing the following.
  • Specification PDF in the form of wombat_x.y.pdf
  • Specification HTML in the form of wombat_x.y.html
  • Specification JavaDoc in the apidocs directory.
  • A specification page named _index.md following the template at:
    https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
  • For a Progress Review, that sufficient progress has been made on
    a Compatible Implementation and TCK, to ensure that the spec is
    implementable and testable.
  • For a Release Review, a summary that a Compatible Implementation
    is complete, passes the TCK, and that the TCK includes sufficient
    coverage of the specification. The TCK users guide MUST include
    the instructions to run the compatible implementations used to
    validate the release. Instructions MAY be by reference.
  • The URL of the OSSRH staging repository for the api, javadoc:

Copy link
Contributor

@bshannon bshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a serious issue, but META-INF/MANIFEST.MF isn't needed here.

I see a reference to the license on the index page but it's missing from the footer of every page.

@kwsutter kwsutter added the draft Work in Progress label Jul 17, 2019
@spericas spericas force-pushed the restful-web-services-apidocs branch from c55d157 to d234ee6 Compare July 17, 2019 15:13
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas force-pushed the restful-web-services-apidocs branch from d234ee6 to 45421fc Compare July 17, 2019 15:33
@spericas
Copy link
Contributor Author

Not a serious issue, but META-INF/MANIFEST.MF isn't needed here.

I see a reference to the license on the index page but it's missing from the footer of every page.

Javadocs updated.

@tomjenkinson
Copy link
Contributor

I noted that the Javadocs seem to have "@SInCE 2.0" and I was expecting these to be "@SInCE JAX-RS 2.0" or similar based on https://www.eclipse.org/lists/ee4j-pmc/msg02056.html but perhaps as the JAX-RS element was not removed for this release (I assume, based on e.g. this file) then it might not be required to actively add this clarification?

@spericas
Copy link
Contributor Author

I noted that the Javadocs seem to have "@SInCE 2.0" and I was expecting these to be "@SInCE JAX-RS 2.0" or similar based on https://www.eclipse.org/lists/ee4j-pmc/msg02056.html

Frankly, we have made most of the API changes before some of those discussions started (or settled). Moreover, we went through the process of eliminating all the "JAX-RS" instances in our docs, so adding those seemed odd at the time; however, if the consensus is to use old acronyms with @since, we can make the change.

but perhaps as the JAX-RS element was not removed for this release (I assume, based on e.g. this file)

Can you elaborate this? I'm not sure which part of that file you're referring to.

@bshannon
Copy link
Contributor

Fixing the @SInCE entries is not critical for this release.

@dblevins
Copy link
Contributor

Not sure if this is a showstopper, but there are some "Java EE" references we might want to convert:

restful-web-services/2.1/apidocs/javax/ws/rs/client/ClientBuilder.html:620: When running in a Java EE container, implementations are required to use the container-managed
restful-web-services/2.1/apidocs/javax/ws/rs/client/ClientBuilder.html:648: When running in a Java EE container, implementations are required to use the container-managed

@spericas
Copy link
Contributor Author

spericas commented Aug 5, 2019

Not sure if this is a showstopper, but there are some "Java EE" references we might want to convert:

restful-web-services/2.1/apidocs/javax/ws/rs/client/ClientBuilder.html:620: When running in a Java EE container, implementations are required to use the container-managed
restful-web-services/2.1/apidocs/javax/ws/rs/client/ClientBuilder.html:648: When running in a Java EE container, implementations are required to use the container-managed

I've changed it to Jakarta EE.

Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas force-pushed the restful-web-services-apidocs branch from fd5db32 to a4f205a Compare August 5, 2019 17:32
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Copy link
Contributor

@bshannon bshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I'm removing the Draft label.
Obviously this still needs to wait for PR #7.

@bshannon bshannon removed the draft Work in Progress label Aug 7, 2019
@ivargrimstad ivargrimstad self-requested a review August 8, 2019 13:06
@kwsutter kwsutter added the draft Work in Progress label Aug 9, 2019
@dblevins
Copy link
Contributor

dblevins commented Aug 9, 2019

This spec is due for review and promotion to vote August 16th. Can you review this checklist and ensure all requirements are met:
https://github.com/jakartaee/specification-committee/blob/master/spec_review_checklist.md

@spericas
Copy link
Contributor Author

spericas commented Aug 9, 2019

This spec is due for review and promotion to vote August 16th. Can you review this checklist and ensure all requirements are met:
https://github.com/jakartaee/specification-committee/blob/master/spec_review_checklist.md

We are working on it and making progress. We should be done in time.

@bshannon bshannon added final Ready for Vote and removed draft Work in Progress labels Aug 15, 2019
@waynebeaton waynebeaton added the ballot Delivered to the Specification Committee for ballot label Aug 19, 2019
@waynebeaton waynebeaton added the approved The ballot was approved by the Specification Committee label Sep 3, 2019
@kwsutter kwsutter merged commit 39a99ab into jakartaee:master Sep 3, 2019
@spericas
Copy link
Contributor Author

spericas commented Sep 4, 2019

@kwsutter It was brought to my attention that the directory name used in this PR is inconsistent with that in #7. I will submit another PR shortly to fix this inconsistency.

@spericas
Copy link
Contributor Author

spericas commented Sep 4, 2019

@kwsutter @bshannon #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The ballot was approved by the Specification Committee ballot Delivered to the Specification Committee for ballot final Ready for Vote
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants