Jakarta Server Faces 2.3 #82

arjantijms · 2019-08-06T23:39:46Z

Signed-off-by: arjantijms arjan.tijms@gmail.com

Specification PR template

When creating a specification project release review, create two PRs with the content divided as follows.

Include the following in PR#1:

A directory in the form wombat/x.y where x.y is the release major.minor version, and the directory contains the following.
Specification PDF in the form of wombat_x.y.pdf
Specification HTML in the form of wombat_x.y.html
A specification page named _index.md following the template at:
https://github.com/jakartaee/specification-committee/blob/master/spec_page_template.md
For a Progress Review, that sufficient progress has been made on
a Compatible Implementation and TCK, to ensure that the spec is
implementable and testable.
For a Release Review, a summary that a Compatible Implementation
is complete, passes the TCK, and that the TCK includes sufficient
coverage of the specification. The TCK users guide MUST include
the instructions to run the compatible implementations used to
validate the release. Instructions MAY be by reference.
The URL of the OSSRH staging repository for the api, javadoc:
https://oss.sonatype.org/content/repositories/staging/jakarta/faces/jakarta.faces-api/2.3.2/
The URL of the staging directory on downloads.eclipse.org for the proposed EFTL TCK binary:
http://download.eclipse.org/ee4j/jakartaee-tck/jakartaee8-eftl/promoted/eclipse-faces-tck-2.3.0.zip
The URL of the compatibility certification request issue:
Compatibility certification request for Jakarta Faces faces#1475

Signed-off-by: arjantijms <arjan.tijms@gmail.com>

smillidge · 2019-08-07T21:29:27Z

api jar doesn't include NOTICE and LICENSE files in the Manifest.

arjantijms · 2019-08-07T23:29:44Z

@smillidge

api jar doesn't include NOTICE and LICENSE files in the Manifest.

Good catch Steve, thx! Updated it right away.

Commit: jakartaee/faces@a389826
Restaged: https://ci.eclipse.org/faces/job/1_faces-build-and-stage/5/consoleText

* Removed version from doctitle * Updated spec doc links * Added TCK link * Updated Compatible implementation link Signed-off-by: arjantijms <arjan.tijms@gmail.com>

* Added spec index * Updated version to 2 digits Signed-off-by: arjantijms <arjan.tijms@gmail.com>

Signed-off-by: arjantijms <arjan.tijms@gmail.com>

NottyCode · 2019-08-19T20:38:32Z

Spec Review Checklist

Spec PR

_index.md

Link to spec pdf
Link to spec html
Link to apidocs
Link to final TCK download zip file of the form https://download.eclipse.org/jakartaee/{spec}/x.y/*{spec}-tck-x.y.z.zip
Link to API jar file of the form https://search.maven.org/artifact/jakarta.{spec}/jakarta.{spec}-api/x.y.z/jar
Name of and link to at least one Compatible Implementation

javadocs

Footer contains Eclipse copyright and link to license
ESFL license is included, usually as doc-files/speclicense.html
no META-INF directory in PR
javadocs-jar artifact matches apidocs (optional for this release)

Spec PDF

Spec HTML

Same as PDF

TCK zip file

README file (optional for this release)
EFTL license file, preferably named LICENSE.md
User's Guide (or equivalent documentation)
How to test the Compatible Implementation(s) listed in _index.md above with the TCK (may be in UG)

TCK User's Guide (or equivalent documentation)

Software requirements listed
Installation and configuration described
How to run tests
Where to file challenges

Compatibility certification request

Request follows template
SHA-256 fingerprint matches staged TCK zip file
Request issue has certification label.

TCK results summary

Page is hosted by Compatible Implementation project
Includes all information from certification request
Summary includes number of tests passed, failed, errors
SHA-256 fingerprint matches staged TCK zip file on cert request

NottyCode · 2019-08-19T20:40:31Z

I found a small number of issues:

I couldn't find the instructions for running it against the CI linked in here. I can find instructions for running against a CI of my choice, or another vendor CI, but I'd been interpreting this step of the checklist relative to the CI listed in this PR.
The TCK certification link lists this SHA has db9a385010cd8544bc1f2468a1fbcaca16f14014fa341e5343c487616f8670dc but when I run shasum -a 256 on the downloaded tck zip I get this 77375ad39f8b736034dbfd554152bbd3e3931a9c9ef1760049c60c5fa87a06d9

arjantijms · 2019-08-20T11:03:58Z

@NottyCode

Thanks for the feedback! You are right about running it, it's not fully trivial. The Faces and Mojarra projects are aware that this is an issue.

I'm not 100% were I should exactly put the instructions and what the format is. @bshannon ?

The short of it is as follows:

Build and stage Mojarra using https://jenkins.eclipse.org/mojarra/job/1_mojarra-build-and-stage
Run the TCK against the staged build using https://jenkins.eclipse.org/mojarra/job/2_mojarra-run-tck-against-staged-build/
Extract and stage the API from the Mojarra build that was staged and passed the TCK using https://ci.eclipse.org/faces/job/1_faces-build-and-stage

We're fully aware that "Extract the API from the Mojarra build" is non-intuitive, and it will be a priority going forward to separate out the API properly into the API project.

I'm going to re-run the TCK and will post the SHA that was actually used during the test to address your second point. Thanks again!

arjantijms · 2019-08-20T12:37:25Z

@NottyCode

TCK now running with artefacts:

SHA256_GF=SHA256(/home/jenkins/workspace/2_mojarra-run-tck-against-staged-build/download/glassfish.zip)= 26f3fa6463d24c5ed3956e4cab24a97e834ca37d7a23d341aadaa78d9e0093ce
SHA256_API=SHA256(/home/jenkins/workspace/2_mojarra-run-tck-against-staged-build/download/jakarta.faces.jar)= 4b8a7b1e91154dcbbbdc952fa599a9071370aad5ce6a377b3c2eacef7972a319
SHA256_TCK=SHA256(/home/jenkins/workspace/2_mojarra-run-tck-against-staged-build/download/facestck.zip)= 77375ad39f8b736034dbfd554152bbd3e3931a9c9ef1760049c60c5fa87a06d9

arjantijms · 2019-08-20T15:12:41Z

TCK passed using the above SHAs: https://jenkins.eclipse.org/mojarra/view/Release/job/2_mojarra-run-tck-against-staged-build/4/consoleText

I'll update the SHA.

bshannon · 2019-08-20T21:17:33Z

@NottyCode

Thanks for the feedback! You are right about running it, it's not fully trivial. The Faces and Mojarra projects are aware that this is an issue.

I'm not 100% were I should exactly put the instructions and what the format is. @bshannon ?

The instructions are supposed to be in the TCK Users Guide here, in the config chapter.
Looks like the implementation-specific instructions were lost in the conversion to AsciiDoc.
Let me see if I can add them back manually...

starksm64 · 2019-08-21T15:42:23Z

The https://eclipse-ee4j.github.io/mojarra/certifications/jakarta-faces/2.3/TCK-Results still has the old SHA rather than 77375ad39f8b736034dbfd554152bbd3e3931a9c9ef1760049c60c5fa87a06d9

kwsutter · 2019-08-21T16:02:20Z

@arjantijms Could you also file a PR for updating jakartaee-api pom.xml with the proper Jakarta Faces API version (2.3.2?). Thanks!

https://github.com/eclipse-ee4j/jakartaee-api/pulls

kwsutter · 2019-08-21T22:31:55Z

@arjantijms Could you also file a PR for updating jakartaee-api pom.xml with the proper Jakarta Faces API version (2.3.2?). Thanks!

https://github.com/eclipse-ee4j/jakartaee-api/pulls

Never mind. If you are good with the 2.3.2 version, I have updated the pom in jakartaee-api for you via PR #34. If you decide on an alternate version, then please submit another PR. Thank you.

arjantijms · 2019-08-21T22:35:50Z

Never mind. If you are good with the 2.3.2 version, I have updated the pom in jakartaee-api for you via PR #34.

Thanks Kevin! 2.3.2 should be perfect. I'm still working on the Authorization updates, and when that is done move back to Faces to address the remaining issues here.

Note to self and others:

As an exception this project also needs additional artefacts published, such as the VDL docs.

arjantijms · 2019-08-23T13:54:29Z

@starksm64

The https://eclipse-ee4j.github.io/mojarra/certifications/jakarta-faces/2.3/TCK-Results still has the old SHA rather than 77375ad39f8b736034dbfd554152bbd3e3931a9c9ef1760049c60c5fa87a06d9

Fixed! Thanks.

arjantijms · 2019-08-23T13:58:05Z

@NottyCode

The TCK certification link lists this SHA has db9a385010cd8544bc1f2468a1fbcaca16f14014fa341e5343c487616f8670dc but when I run shasum -a 256 on the downloaded tck zip I get this 77375ad39f8b736034dbfd554152bbd3e3931a9c9ef1760049c60c5fa87a06d9

Should now be fixed, can you check again and if correct set the checkboxes? Thx!

Signed-off-by: arjantijms <arjan.tijms@gmail.com>

bshannon · 2019-09-09T16:39:47Z

On ballot completion

The designated specification committee representative adds this final checklist to the main PR.
The specification committee representative merges the specification and apidocs PRs.
The designated specification committee representative calculates the staged EFTL TCK signature and promotes it to the committee download area
using the https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/ job.
The specification project member who created the staging release promotes the specification api jars to maven central. An example release job script can be found here https://wiki.eclipse.org/MavenReleaseScript.
The EMO updates the specification page with the ballot results.
This list goes on the committed spec index page.
The specification project team should go through the merged spec website page to verify all the links are valid.
The specification project team should approve the compatibility request.
The compatible implementation project/vendor MUST send an email tck@eclipse.org for approval of the compatible implementation for trademark usage.
The specification project team should merge any final release branch as appropriate for the branch management for the project.

arjantijms · 2019-09-10T02:04:18Z

Final release branch PR: jakartaee/faces#1478

arjantijms · 2019-09-10T02:08:47Z

Mail sent

bshannon · 2019-09-10T02:55:47Z

@arjantijms Looks like the API jar file hasn't been released.

arjantijms · 2019-09-10T04:15:05Z

@bshannon you're right, but it's there now:

https://repo1.maven.org/maven2/jakarta/faces/jakarta.faces-api/2.3.2/

Thx!

Jakarta Server Faces 2.3

81390a0

Signed-off-by: arjantijms <arjan.tijms@gmail.com>

arjantijms mentioned this pull request Aug 6, 2019

Prepare Jakarta Server Faces for Jakarta EE 8 Release eclipse-ee4j/mojarra#4582

Closed

6 tasks

kwsutter added the draft Work in Progress label Aug 7, 2019

arjantijms added 3 commits August 13, 2019 01:15

Updated for latest requirements:

389f343

* Removed version from doctitle * Updated spec doc links * Added TCK link * Updated Compatible implementation link Signed-off-by: arjantijms <arjan.tijms@gmail.com>

* Removed images

ebd7bf1

* Added spec index * Updated version to 2 digits Signed-off-by: arjantijms <arjan.tijms@gmail.com>

Update TCK link to future final

0c3765f

Signed-off-by: arjantijms <arjan.tijms@gmail.com>

Added links to alt docs

5207c78

Signed-off-by: arjantijms <arjan.tijms@gmail.com>

starksm64 added final Ready for Vote and removed draft Work in Progress labels Aug 23, 2019

waynebeaton added the ballot Delivered to the Specification Committee for ballot label Aug 26, 2019

waynebeaton added the approved The ballot was approved by the Specification Committee label Sep 9, 2019

bshannon merged commit bde243f into jakartaee:master Sep 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jakarta Server Faces 2.3 #82

Jakarta Server Faces 2.3 #82

arjantijms commented Aug 6, 2019 •

edited

smillidge commented Aug 7, 2019

arjantijms commented Aug 7, 2019

NottyCode commented Aug 19, 2019 •

edited by starksm64

NottyCode commented Aug 19, 2019

arjantijms commented Aug 20, 2019

arjantijms commented Aug 20, 2019

arjantijms commented Aug 20, 2019

bshannon commented Aug 20, 2019

starksm64 commented Aug 21, 2019

kwsutter commented Aug 21, 2019 •

edited

kwsutter commented Aug 21, 2019

arjantijms commented Aug 21, 2019

arjantijms commented Aug 23, 2019

arjantijms commented Aug 23, 2019

bshannon commented Sep 9, 2019 •

edited

arjantijms commented Sep 10, 2019

arjantijms commented Sep 10, 2019

bshannon commented Sep 10, 2019

arjantijms commented Sep 10, 2019

Jakarta Server Faces 2.3 #82

Jakarta Server Faces 2.3 #82

Conversation

arjantijms commented Aug 6, 2019 • edited

Specification PR template

smillidge commented Aug 7, 2019

arjantijms commented Aug 7, 2019

NottyCode commented Aug 19, 2019 • edited by starksm64

Spec Review Checklist

NottyCode commented Aug 19, 2019

arjantijms commented Aug 20, 2019

arjantijms commented Aug 20, 2019

arjantijms commented Aug 20, 2019

bshannon commented Aug 20, 2019

starksm64 commented Aug 21, 2019

kwsutter commented Aug 21, 2019 • edited

kwsutter commented Aug 21, 2019

arjantijms commented Aug 21, 2019

arjantijms commented Aug 23, 2019

arjantijms commented Aug 23, 2019

bshannon commented Sep 9, 2019 • edited

arjantijms commented Sep 10, 2019

arjantijms commented Sep 10, 2019

bshannon commented Sep 10, 2019

arjantijms commented Sep 10, 2019

arjantijms commented Aug 6, 2019 •

edited

NottyCode commented Aug 19, 2019 •

edited by starksm64

kwsutter commented Aug 21, 2019 •

edited

bshannon commented Sep 9, 2019 •

edited