Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that there are no encoded symbols in the jar file paths #198

Merged
merged 1 commit into from
May 17, 2024

Conversation

marko-bekhta
Copy link
Contributor

Hey @starksm64 ,

I was looking into problems running a TCK on CI after some unrelated upgrades, and noticed that using code source location can result in a path like:

file:/var/lib/jenkins/workspace/hibernate-validator_PR-1347%40tmp/maven-repository/org/assertj/assertj-core/3.8.0/assertj-core-3.8.0.jar

where @ is encoded (%40) and which results in this file being not found. The suggested change to call toURI should address the encoding/decoding issue.

@gsmet
Copy link
Contributor

gsmet commented Apr 22, 2024

@starksm64 I'm not sure what the process is nowadays so I didn't merge it but this looks good to me and would unblock some Hibernate Validator work if you could get something released.

Thanks!

@yrodiere
Copy link

Hey @starksm64,

Bump?

@starksm64 I'm not sure what the process is nowadays so I didn't merge it but this looks good to me and would unblock some Hibernate Validator work if you could get something released.

Thanks!

@starksm64 starksm64 merged commit 7afe439 into jakartaee:main May 17, 2024
1 check passed
@starksm64
Copy link
Contributor

So do you need a service release of the TCK?

@marko-bekhta
Copy link
Contributor Author

Hey,

So do you need a service release of the TCK?

yes, that would be nice. if we get this patch released then we'd be able to move forward with the Hibernate Validator work. Thanks!

@Emily-Jiang
Copy link

@marko-bekhta we discussed at the platform call today for requesting a service release to take this PR in. In order to do a service release, a challenge is need. Can you raise an issue here with the tag of Challenge? Once it is created and accepted, a service release can be done.

@marko-bekhta
Copy link
Contributor Author

Hey @Emily-Jiang
I've created jakartaee/validation-spec#284. I cannot add labels to the created issue though... Let me know if there's anything else needed to move this forward. Thanks!

@starksm64
Copy link
Contributor

Nothing else required, I'll release the 3.1.1 service today

@marko-bekhta
Copy link
Contributor Author

Thanks a lot!

@Emily-Jiang
Copy link

Thank you @marko-bekhta @starksm64 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants