Skip to content

Commit

Permalink
Fix #231 - Clarify how HTTP headers are exposed through the API
Browse files Browse the repository at this point in the history
Signed-off-by: Mark Thomas <markt@apache.org>
  • Loading branch information
markt-asf committed May 7, 2020
1 parent 5426d2c commit 2b25239
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2018, 2019 Oracle and/or its affiliates and others.
* Copyright (c) 2018, 2020 Oracle and/or its affiliates and others.
* All rights reserved.
*
* This program and the accompanying materials are made available under the
Expand All @@ -21,7 +21,7 @@
import java.util.Map;

/**
* The handshake response represents the web socket-defined Http response that is the response to the opening handshake
* The handshake response represents the WebSocket-defined HTTP response that is the response to the opening handshake
* request.
*
* @author dannycoward
Expand All @@ -34,9 +34,10 @@ public interface HandshakeResponse {
static final String SEC_WEBSOCKET_ACCEPT = "Sec-WebSocket-Accept";

/**
* Return the list of Http headers sent by the web socket server.
* Return the map of HTTP headers to header values sent by the WebSocket server. Note that the lookup of header
* names will be performed in a case insensitive manner.
*
* @return the http headers .
* @return the HTTP headers.
*/
Map<String, List<String>> getHeaders();
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2018, 2019 Oracle and/or its affiliates and others.
* Copyright (c) 2018, 2020 Oracle and/or its affiliates and others.
* All rights reserved.
*
* This program and the accompanying materials are made available under the
Expand All @@ -23,7 +23,7 @@
import java.util.Map;

/**
* The handshake request represents the web socket defined Http GET request for the opening handshake of a web socket
* The handshake request represents the WebSocket defined HTTP GET request for the opening handshake of a WebSocket
* session.
*
* @author dannycoward
Expand All @@ -47,8 +47,8 @@ public interface HandshakeRequest {
static String SEC_WEBSOCKET_EXTENSIONS = "Sec-WebSocket-Extensions";

/**
* Return the read only Map of Http Headers that came with the handshake request. The header names are case
* insensitive.
* Return the read only map of HTTP headers to header values that came with the handshake request. Note that the
* lookup of header names will be performed in a case insensitive manner.
*
* @return the list of headers.
*/
Expand Down

0 comments on commit 2b25239

Please sign in to comment.