Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make] No instructions to clone git submodules prior to using make #96

Closed
chris-lansman opened this issue Feb 21, 2023 · 4 comments
Closed

Comments

@chris-lansman
Copy link

Downloaded the latest source and attempted to compile on ubuntu 20.04, you receive this error
CXX src/util.cpp In file included from src/util.h:2, from src/util.cpp:1: src/types.h:2:10: fatal error: tc/types.h: No such file or directory 2 | #include <tc/types.h> | ^~~~~~~~~~~~ compilation terminated. make: *** [makefile:130: src/util.o] Error 1

After spending an hour+ googling around this file as far as I can surmise no longer lives in the tc tool which is now part of the iproute2 package.

Please consider updating these dependencies or at least making a link or download available on where to get them from in order to compile the code.

I attempted to run your pre-compiled and it died trying to find old versions of GLIBC. Consider recompiling with a new version of Linux or specifying what you are running.

@jakcron
Copy link
Owner

jakcron commented Feb 21, 2023

It's actually part of libtoolchain, I see it's missing from the build steps so i will just tell you here, and update it later.

The deps/ directory contains all the local dependencies required to build NSTool.
But they are git submodules, so when first cloning the source code you need to init the git submodules and clone them with these two commands:

git submodule init
git submodule update

@jakcron jakcron changed the title [make] Update outdated missing files [make] No instructions to clone git submodules prior to using make Mar 20, 2023
@jakcron
Copy link
Owner

jakcron commented Mar 20, 2023

I attempted to run your pre-compiled and it died trying to find old versions of GLIBC. Consider recompiling with a new version of Linux or specifying what you are running.

The pre-compiled binaries are built using Github Actions, Ubuntu builds specifically use ubuntu-latest, so there's not much chance of it being built with a "newer" version of linux.

@jakcron
Copy link
Owner

jakcron commented Dec 31, 2023

Instructions added to BUILDING.md in development-tip (0d248d1). This should be present in any release post 1.8.0

@jakcron
Copy link
Owner

jakcron commented Dec 31, 2023

Released in NSTool v1.8.1

@jakcron jakcron closed this as completed Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants