TypeScript: special case for auto-incrementing primary keys #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional string
autoIncrementKeyPath
property to theDBSchemaValue
type. When present, any values returned from idb (such as fromget
orgetAll
) will have a numeric value at that key value.I tried it in a project I'm porting from my own untyped IndexedDB promise wrapper to idb with the goal of reducing the number of
any
s in my code, and it's really cool to see this working!On the other hand, I understand that this is a little complicated and possibly more confusing than it's worth, so I'd appreciate your thoughts!
It also might be worth adding some tests of the TypeScript types like described here to ensure that it continues to work in the future. I'm not sure though, I've never done something like that.
Resolves #150