Add type="button" in buttons.

The default is `type="submit"`
jakearchibald · Sep 24, 2021 · 18e18a7 · 18e18a7
1 parent 00bfc58
commit 18e18a7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/index.html b/src/index.html
@@ -89,7 +89,7 @@ <h1>SVGOMG</h1>
       </div>
       <div class="toolbar">
         <div class="menu-toolbar-item">
-          <button class="unbutton menu-btn">
+          <button class="unbutton menu-btn" type="button">
             {% include "partials/icons/menu.svg" %}
           </button>
         </div>
@@ -156,7 +156,7 @@ <h1 class="settings-sub-heading">Features</h1>
               {% endfor %}
             </section>
             <div class="setting-reset-row">
-              <button class="unbutton setting-reset">Reset all</button>
+              <button class="unbutton setting-reset" type="button">Reset all</button>
             </div>
           </div>
         </div>

diff --git a/src/js/page/ui/toasts.js b/src/js/page/ui/toasts.js
@@ -16,6 +16,7 @@ class Toast {
     for (const button of buttons) {
       const buttonElement = document.createElement('button');
       buttonElement.className = 'unbutton';
+      buttonElement.type = 'button';
       buttonElement.textContent = button;
       buttonElement.addEventListener('click', () => {
         this._answerResolve(button);