Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused import patterns, fix project for Django > 1.8 #13

Merged
merged 6 commits into from May 7, 2017
Merged

Remove unused import patterns, fix project for Django > 1.8 #13

merged 6 commits into from May 7, 2017

Conversation

tonythomas01
Copy link
Contributor

The import was showing up error on later Django versions (Now its 1.11+)

jakeharding
jakeharding reviewed May 7, 2017
View reviewed changes
Copy link
Owner

@jakeharding jakeharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! This project definitely needs to be updated. If I support Django 1.10 and 1.11, those versions need to added to the tox tests. Are you familiar with tox?

jakeharding
jakeharding reviewed May 7, 2017
View reviewed changes
Copy link
Owner

@jakeharding jakeharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could edit this pull request so it will be merged into develop?

tox.ini

[testenv]
deps =
pytest
pytest-django
django18: Django==1.8.10
django19: Django==1.9.3
django110: Django==1.10.4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the latest Django version also: 1.11.1 I believe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havent personally tried it with Django=1.11.1. Let me get travis run it on 1.10.4, and if that goes green - will add for sure.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a branch that takes care of most it if you want to add 1.11.1 and change the base to develop we can merge it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am trying to fix the issues with 1.10 now. Looks like some reverse imports from somewhere else post 1.10.

@tonythomas01
Copy link
Contributor Author

Could edit this pull request so it will be merged into develop?

Ah. missed that :-(

@tonythomas01
Copy link
Contributor Author

Alright. Let me push this to the development branch.

@tonythomas01 tonythomas01 changed the base branch from master to develop May 7, 2017 22:10
@tonythomas01
Copy link
Contributor Author

If the tests pass, I think we are done here.

@jakeharding jakeharding merged commit cfa35bc into jakeharding:develop May 7, 2017
@jakeharding
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakeharding jakeharding jakeharding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tonythomas01 @jakeharding