Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/convert tables #2

Closed
wants to merge 22 commits into from
Closed

Feature/convert tables #2

wants to merge 22 commits into from

Conversation

creisle
Copy link
Collaborator

@creisle creisle commented Oct 21, 2021

Breaking changes

  • re-write of xml content parsing to increase flexibility (now can keep track of xml path and customize/overload tag handlers)
  • moved code under src folder

XML Content Changes

  • can turn off sentence truncating with new option
  • default includes tables (let me know if this would break anything for you)
  • default keep local element xrefs (ex. Figure 1, Table 2)
  • Do not add extra spaces around deleted XML elements

New Features

  • created a tests folder and added some unit tests
  • added a markdown/docs file for the bioconverters package

TODO (before merge)

the following require admin and must be done by @jakelever

  • The build needs codecov to be set up to pass, otherwise the tests are ok (https://app.codecov.io/gh/+)
  • the PYPI credentials need to be set up in secrets so that the package will auto-publish to pypi when a tag is created

@creisle creisle added the enhancement New feature or request label Oct 21, 2021
@creisle creisle self-assigned this Oct 21, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@cb0e9d9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   54.74%           
=========================================
  Files             ?        5           
  Lines             ?      559           
  Branches          ?        0           
=========================================
  Hits              ?      306           
  Misses            ?      253           
  Partials          ?        0           
Flag Coverage Δ
unittests 54.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb0e9d9...f000e6c. Read the comment docs.

@creisle
Copy link
Collaborator Author

creisle commented Oct 31, 2021

Found some ways to improve this. I'm going to close this and make a new one once i have that figured out more

@creisle creisle closed this Oct 31, 2021
@creisle creisle deleted the feature/convert-tables branch November 1, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants