Initialize static variables atomically #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemarsh
added a commit
that referenced
this pull request
Mar 10, 2013
Initialize static variables atomically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Jake,
Thanks for the useful library. I've noticed that some global variables are not initialized atomically. I haven't run into any problems but I think it would be safer to initialize them using
dispatch_once, to prevent potential race conditions between the very first two calls tosetImageURL.... If you place breakpoints in both places and remove the call toremoveAllImagesfrom the demo program, you can see that they are indeed being called from different threads.