Use "Partialify" to include templates #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, if you can just resolve the merge conflicts I'll merge it in! |
…"magic" template paths, and to add html files to the dependency graph
DrewML
force-pushed
the
partialifyAllTheTemplates
branch
from
2c73eb2
to
0767746
Compare
|
Fixed merge conflicts, and cleaned up history a bit. |
jakemmarsh
added a commit
that referenced
this pull request
Mar 28, 2015
Use "Partialify" to include templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy,
With this PR, I am recommending switching from the
gulp-angular-templatecacheplugin to thepartialifyplugin. Here are the reasons that make me believe this is a good choice:templateUrlfield. When new developers use this boilerplate, they will likely be able to make more sense of arequirecall to a specific path on disk, instead of guessing whyhome.htmljust seems to work.template.jsfile into a directory meant for source files. This removes that necessity, keeping the source directory cleaner.