Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove executive rights from assets #46

Merged
merged 1 commit into from
Aug 17, 2015

Conversation

strzibny
Copy link
Contributor

New version of sprite-factory have an executive bit set for some assets. This is what shows gem-compare:

$ gem compare sprite-factory 1.6.2 1.7 -kb
Fetching: sprite-factory-1.7.gem (100%)
Compared versions: ["1.6.2", "1.7"]
  DIFFERENT files:
    1.6.2->1.7:
      * Added:
            test/images/glob/
            test/images/names/
            test/images/glob/excluded1.png
              (!) Unexpected permissions: 100775
              (!) File is executable
            test/images/glob/excluded2.png
              (!) Unexpected permissions: 100775
              (!) File is executable
            test/images/glob/included1.png
              (!) Unexpected permissions: 100775
              (!) File is executable
            test/images/glob/included2.png
              (!) Unexpected permissions: 100775
              (!) File is executable
            test/images/glob/included3.png
              (!) Unexpected permissions: 100775
              (!) File is executable
            test/images/names/Ends With Bang!.png
              (!) Unexpected permissions: 100775
              (!) File is executable
            test/images/names/Has & Ampersand.png
              (!) Unexpected permissions: 100775
              (!) File is executable
            test/images/names/Odd.Period.png
              (!) Unexpected permissions: 100775
              (!) File is executable
            test/images/reference/glob.css
              (!) Unexpected permissions: 100664
            test/images/reference/glob.png
              (!) Unexpected permissions: 100664
            test/images/reference/sanitized.css
              (!) Unexpected permissions: 100664
            test/images/reference/sanitized.custom.css
              (!) Unexpected permissions: 100664
            test/images/reference/sanitized.custom.png
              (!) Unexpected permissions: 100664
            test/images/reference/sanitized.png
              (!) Unexpected permissions: 100664
    1.6.2->1.7:
      * Updated
            rmagick from: ["= 2.13.2"] to: ["= 2.13.4"]

This PR fixes the issue.

jakesgordon added a commit that referenced this pull request Aug 17, 2015
Remove executive rights from assets
@jakesgordon jakesgordon merged commit 350146c into jakesgordon:master Aug 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants