License Generator Interactive Mode #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the keygen process a bit easier I've added a `generate-keys.sh` script that can be found in the `.keys` directory. It will generate the key & cert and bundle them into the required pkcs#12 file. I've updated the readme to include instructions on the script.
Added the generation of a second modified container, bitbetter/identity, which contains the modified dll. Fixes #12. This works on my testing environment but has not gone through extensive testing. I'd recommend a review and cleanup of this commit before it is merged into the develop or master branches.
I've taken the steps written out by @online-stuff and consolidated/organized them into the README. This closes #13. In a future update it might be worth adding a docs/ directory and breaking the readme into several docs that link to one another.
Build now checks for and creates missing .keys directories.
Don't overwrite if keys already exist.
Never versions of the dotnet-sdk have issues with older Newtonsoft versions. 12.0.1 seems to satisfy the widest variety of sdk versions.
…ctive-licensegen Merging changes in anticipation of pull request.
This fixes and closes issue #24.
|
Hey @jakeswenson & @online-stuff , on top of the new features, there are a number of outstanding issues that are fixed in this PR. If one of you is able to review it it will help us solve several recent issues. |
jakeswenson
approved these changes
Jun 5, 2019
|
Looks good to me! I wonder if there is a way to reduce some of the nesting in the license generator, but not a major issue. |
Yeah, at some point I'm going to try to re-organize the project but I didn't want to do that at the same time as adding a feature. |
This was referenced Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the rough plan I laid out in #22, I've implemented the interactive mode for the license generator as part of the push to simplify the use of the tool. The Readme has been updated with the details on using the new mode, as well.
In addition, the tool now optionally accepts a BusinessName parameter for org licenses, solving #21.
More detail is provided in the Readme, but the basic use of interactive mode is as follows:
If you generated your keys in the default
BitBetter/.keysdirectory, you can simply run the license gen in interactive mode from theBitbetterdirectory and follow the prompts to generate your license.That's it.
If you wish to run the license gen from a directory aside from the root
BitBetterone, you'll have to provide the absolute path to your cert.pfx.Of course, the previous modes of operation still function as they did before.