Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated requirements, fixed line endings of assemblies.manifest.new #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpstotz
Copy link

@jpstotz jpstotz commented Apr 4, 2023

On Windows the original version of pyxamstore created line endings \r\r\n (0x0D 0x0D 0x0A) which looked strange and most likely will not be accepted by Xamarin (not tested).
The Xamarin app I was checking had only 0x0A in its assemblies.manifest so I would assume always just using \n is the best solution.

@jakev
Copy link
Owner

jakev commented May 19, 2023

Hi Jan - Thanks for the pull request! I'll look into this and merge it if it all works! :)

@jakev
Copy link
Owner

jakev commented May 19, 2023

Actually quick question - I assume you're unpacking the APK using apktool on Windows? @jpstotz

@jpstotz
Copy link
Author

jpstotz commented May 20, 2023

I assume you're unpacking the APK using apktool on Windows? @jpstotz

@jakev Yes often apktool or just a simple unzip tool like 7-zip, Winrar, ... All these tools don't process/alter the line endings so it should not make a difference which too is used for unpacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants