Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Portuguese - Brazil #52

Merged
merged 14 commits into from
Jun 21, 2022
Merged

Conversation

Gabrielforest
Copy link
Contributor

I have used the same structure from es

@jakewilliami
Copy link
Owner

Hey @Gabrielforest, this looks great, thanks so much for contributing! I changed the structure a bit to be more consistent with the other supported languages (namely to be more consistent with the interface for English).

I'd like to raise a couple of questions:

  1. Do you know if Portugal Portuguese is the same as Brazilian Portuguese in terms of counting? I know that pronunciation is quite different, but I'm not so familiar so am unsure about counting. If they are the same then we can rename :pt_BR -> :pt.
  2. Would you mind adding some more tests for Brazilian Portuguese? I think we should test floats, if you have implemented them, and just add some more test cases.

Thank you again for your help. Great work!

@Gabrielforest
Copy link
Contributor Author

Hi! @jakewilliami in terms of counting they are the same. The spelling is a bit different but I am capable to make this implementation as well with some research on the internet and then some native speaker could help us with corrections...
What do you think?
And I will add more tests! No problem.

Thank you!

@jakewilliami
Copy link
Owner

@Gabrielforest, once again, great work! I wonder if it's possible to merge pt.jl and pt_BR.jl into one function, if the only difference is spelling? It would make sense that way—would you agree? If you need help implementing this, please let me know.

@Gabrielforest
Copy link
Contributor Author

@jakewilliami I have made this implementation. Indeed much better now!

@jakewilliami
Copy link
Owner

Great work Gabriel! Sorry it has taken me a while to get back to you. It's looking good. One more thing: the tests seem to be failing now. Can you take a look? I can debug if you are too busy.

@Gabrielforest
Copy link
Contributor Author

Thank you! I just fixed it, haven't seen your last message sorry about that.

@jakewilliami
Copy link
Owner

Great work Gabriel! Looks great :) I'll merge now.

@jakewilliami jakewilliami merged commit c01f8c1 into jakewilliami:master Jun 21, 2022
jakewilliami added a commit that referenced this pull request Mar 29, 2023
Implement language support for Portuguese
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants