-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Portuguese - Brazil #52
Conversation
Hey @Gabrielforest, this looks great, thanks so much for contributing! I changed the structure a bit to be more consistent with the other supported languages (namely to be more consistent with the interface for English). I'd like to raise a couple of questions:
Thank you again for your help. Great work! |
Hi! @jakewilliami in terms of counting they are the same. The spelling is a bit different but I am capable to make this implementation as well with some research on the internet and then some native speaker could help us with corrections... Thank you! |
@Gabrielforest, once again, great work! I wonder if it's possible to merge |
@jakewilliami I have made this implementation. Indeed much better now! |
Great work Gabriel! Sorry it has taken me a while to get back to you. It's looking good. One more thing: the tests seem to be failing now. Can you take a look? I can debug if you are too busy. |
Thank you! I just fixed it, haven't seen your last message sorry about that. |
Great work Gabriel! Looks great :) I'll merge now. |
Implement language support for Portuguese
I have used the same structure from
es