-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise English implementation #53
Merged
Merged
Commits on Jun 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 25aa38e - Browse repository at this point
Copy the full SHA 25aa38eView commit details
Commits on Jun 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c0f0664 - Browse repository at this point
Copy the full SHA c0f0664View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99fbc78 - Browse repository at this point
Copy the full SHA 99fbc78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22e2773 - Browse repository at this point
Copy the full SHA 22e2773View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c1eabe - Browse repository at this point
Copy the full SHA 8c1eabeView commit details -
Instead of creating IOBuffers within each function, pass around IOBuffers to modifying functions and only take from them at the end of the process! This vastly reduces the allocations as we are no longer creating a new IOBuffer within each function. However, it is still not as fast as it was (but its memory usage is better).
Configuration menu - View commit details
-
Copy full SHA for 3175b96 - Browse repository at this point
Copy the full SHA 3175b96View commit details -
Configuration menu - View commit details
-
Copy full SHA for b40d835 - Browse repository at this point
Copy the full SHA b40d835View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9403ed - Browse repository at this point
Copy the full SHA a9403edView commit details
Commits on Jun 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 00f458a - Browse repository at this point
Copy the full SHA 00f458aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fb5af2 - Browse repository at this point
Copy the full SHA 7fb5af2View commit details -
Better string manipulation and use buf for niche convert funcs
Instead of using a weird `reverse` method for string manipulation in printing of ordinals, we use a util function. Also, use `IOBuffer` where practical for alt convert methods
Configuration menu - View commit details
-
Copy full SHA for d2f1fef - Browse repository at this point
Copy the full SHA d2f1fefView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8f2a97 - Browse repository at this point
Copy the full SHA a8f2a97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b2bc8b - Browse repository at this point
Copy the full SHA 9b2bc8bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.