Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MkdnToggleTodo doesn't take the header back to Done state. #31

Closed
2 tasks
abhijeetsrivastava opened this issue May 3, 2022 · 5 comments
Closed
2 tasks
Assignees
Labels
bug Something isn't working

Comments

@abhijeetsrivastava
Copy link

abhijeetsrivastava commented May 3, 2022

MkdnToggleTodo doesn't take the header back to Done state.

I am getting the following error

E5108: Error executing lua ...e/pack/packer/start/mkdnflow.nvim/lua/mkdnflow/lists.lua:68: bad argument #1 to 'match' (string expected, got nil) stack traceback: [C]: in function 'match' ...e/pack/packer/start/mkdnflow.nvim/lua/mkdnflow/lists.lua:68: in function 'get_status' ...e/pack/packer/start/mkdnflow.nvim/lua/mkdnflow/lists.lua:102: in function 'same_siblings' ...e/pack/packer/start/mkdnflow.nvim/lua/mkdnflow/lists.lua:182: in function 'update_parent_to_do' ...e/pack/packer/start/mkdnflow.nvim/lua/mkdnflow/lists.lua:249: in function 'toggleToDo' [string ":lua"]:1: in main chunk

Steps I followed

  1. Created
  • parent
    • child
  1. I toggled child and both the child and parent toggled to In progress state
  2. Again toggled child to done state but parent state didn't change and got the error.
@jakewvincent
Copy link
Owner

Reproduced it on my end... I'll look into this in a moment!

@jakewvincent
Copy link
Owner

So I found this is happening on my end if the child to-do is on the last line of the document. To get it working before I push a fix, just make sure there's a blank line before the end of the document

@jakewvincent
Copy link
Owner

Should be fixed now. Can you report back after updating the plugin?

@jakewvincent jakewvincent added the bug Something isn't working label May 3, 2022
@jakewvincent jakewvincent self-assigned this May 3, 2022
@jakewvincent
Copy link
Owner

Closing this issue since I believe this is fixed, but please let me know if this is still happening for you after updating, @abhijeetsrivastava

@abhijeetsrivastava
Copy link
Author

Yes its now working. Thanks @jakewvincent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants