Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add greater accessibility support #21

Closed
jakezatecky opened this issue Feb 16, 2017 · 1 comment
Closed

Add greater accessibility support #21

jakezatecky opened this issue Feb 16, 2017 · 1 comment
Labels
enhancement

Comments

@jakezatecky
Copy link
Owner

Icon-only buttons are not readily consumable by screen readers. There should be alternative text instead or aria-label should be used. Click handlers on <span> elements are also not semantic and <label>s without targets may also hinder accessibility.
jakezatecky added a commit that referenced this issue Feb 16, 2017
@jakezatecky
Add aria-label to toggle buttons
e99c5fa 
Addresses #21
jakezatecky added a commit that referenced this issue Feb 16, 2017
@jakezatecky
Add aria-label to toggle buttons
2c7313a 
Addresses #21
@jakezatecky
Copy link
Owner Author

Also addressed in 5198501.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakezatecky