Make Struct object for pointer_to_nested_list
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of calling `struct.unpack` using `fmt` within `pointer_to_nested_list`, make a `Struct` object and pass its `unpack` method into `pointer_to_nested_list`. As `struct.unpack` ends up constructing a `Struct` object anyways, this ends up being lower overhead as the same `Struct` object can be reused for all conversions of `bytes` from the buffer into Python values. Benchmarking of the different `unpack` cases verifies this improves the runtime over 2x. Benchmarking `cybuffer`'s `tolist` with and without this changes also shows a significant improvement. With this change, `tolist`s runtime is roughly halved. Though it remains roughly 4x slower than NumPy, this is a significant performance improvement. Should also be a good point to build on for further performance improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calling
struct.unpackusingfmtwithinpointer_to_nested_list, make aStructobject and pass itsunpackmethod intopointer_to_nested_list. Asstruct.unpackends up constructing aStructobject anyways, this ends up being lower overhead as the sameStructobject can be reused for all conversions ofbytesfrom the buffer into Python values. Benchmarking of the differentunpackcases verifies this improves the runtime over 2x.Benchmarking
cybuffer'stolistwith and without this changes also shows a significant improvement. With this change,tolists runtime is roughly halved. Though it remains roughly 4x slower than NumPy, this is a significant performance improvement. Should also be a good point to build on for further performance improvements.