Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document cdist's/pdist's keyword arguments V, VI, and w #69

Merged
merged 6 commits into from
Oct 6, 2017

Conversation

jakirkham
Copy link
Owner

@jakirkham jakirkham commented Oct 6, 2017

Missed documenting the keyword arguments V, VI, and w of cdist and pdist when adding the metrics seuclidean, mahalanobis, and wminkowski respectively in PR ( #66 ). This corrects that oversight by adding brief explanations of them to the docstring.

Missed documenting `V` when adding support for the `seuclidean` metric
in `cdist`. So this adds documentation for that parameter along with a
brief explanation of how the default value is determined.
Missed documenting `V` when adding support for the `seuclidean` metric
in `pdist`. So this adds documentation for that parameter along with a
brief explanation of how the default value is determined.
Missed documenting `VI` when adding support for the `mahalanobis` metric
in `cdist`. So this adds documentation for that parameter along with a
brief explanation of how the default value is determined.
Missed documenting `VI` when adding support for the `mahalanobis` metric
in `pdist`. So this adds documentation for that parameter along with a
brief explanation of how the default value is determined.
Missed documenting `w` when adding support for the `wminkowski` metric
in `cdist`. So this adds documentation for that parameter and notes that
it is mandatory (no default).
Missed documenting `w` when adding support for the `wminkowski` metric
in `pdist`. So this adds documentation for that parameter and notes that
it is mandatory (no default).
@jakirkham jakirkham changed the title Document cdist's and pdist's keyword arguments V and VI Document cdist's and pdist's keyword arguments V, VI, and w Oct 6, 2017
@jakirkham jakirkham changed the title Document cdist's and pdist's keyword arguments V, VI, and w Document cdist's/pdist's keyword arguments V, VI, and w Oct 6, 2017
@jakirkham jakirkham merged commit e8d3559 into master Oct 6, 2017
@jakirkham jakirkham deleted the dists_doc_more_kwargs branch October 6, 2017 20:32
@jakirkham jakirkham changed the title Document cdist's/pdist's keyword arguments V, VI, and w Document cdist's/pdist's keyword arguments V, VI, and w Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant