Skip to content

Commit

Permalink
Merge pull request #48 from jakirkham/catch_more_unknown_lens
Browse files Browse the repository at this point in the history
Raise more unknown length cases
  • Loading branch information
jakirkham committed Jan 17, 2017
2 parents 8bde7c5 + 8ff9945 commit 84292f6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion kenjutsu/measure.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def len_slice(a_slice, a_length=None):
if (new_slice.step > 0 and new_slice.start >= 0 and
(new_slice.stop is None or new_slice.stop < 0)):
raise UnknownSliceLengthException(
"Cannot determine slice length without a defined start"
"Cannot determine slice length without a defined end"
" point. The reformatted slice was %s." % repr(new_slice)
)
elif (new_slice.step < 0 and new_slice.start < 0 and
Expand Down
6 changes: 6 additions & 0 deletions tests/test_measure.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,15 @@ def test_len_slice(self):
with self.assertRaises(measure.UnknownSliceLengthException):
measure.len_slice(slice(None))

with self.assertRaises(measure.UnknownSliceLengthException):
measure.len_slice(slice(0, -1, 1))

with self.assertRaises(measure.UnknownSliceLengthException):
measure.len_slice(slice(None, None, -1))

with self.assertRaises(measure.UnknownSliceLengthException):
measure.len_slice(slice(-1, 1, -1))

for size in [10, 11, 12]:
excess = size + 3
each_range = range(size)
Expand Down

0 comments on commit 84292f6

Please sign in to comment.