Reuse current image #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra slicing step exists to handle converting some internal Lazy objects from the workflow into NumPy arrays. The `asarray` call exists to convert Dask Arrays to NumPy arrays. Hence it makes sense to roll these into the same step to guarantee an array is provided for `cur_img` before doing type conversion. Previously Dask would have handled the type conversion as well. However the type conversion is trivially performed locally. Plus it is easier to reason about if a NumPy array is guaranteed at this step.
Instead of waiting until the retrieval of the 2-D/3-D data slice, check to determine what the selected frame is at the beginning of `get_image`.
There really isn't time for the 2-D case. However it can effectively be treated as having a single time slice at 0. Hence we fill in the default `i` for that case. Though it is not actually use in any later code.
jakirkham
force-pushed
the
reuse_cur_img
branch
from
2845a60
to
ab80716
Compare
When working with large data on a slow filesystem, re-reading the current displayed image is unnecessarily slow. This happens when checking the intensity of different coordinates for instance (via mouseover events). To improve performance, we can store the currently displayed frame and simply access it if the user has not selected a different frame. We accomplish this here by storing the frame number (time) and the current frame's data. These are both initialized to be `None` so that they will fail cache hits the first time. Within `get_image`, checks are added to see if the current frame number (time) and requested one are the same. If not, the new frame is loaded and the cache values updated once loading completes. This ensures that some raised exception doesn't create an incorrectly determined cached state. Whether or not the frame is current or new, the frame is returned.
Add some checks to make sure that if the same frame is retrieved again (pulled from cache) that it still retrieves the image correctly.
jakirkham
force-pushed
the
reuse_cur_img
branch
from
ca6cda0
to
4e1fecc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to reuse the current image displayed in
get_imagecalls. Should speed up operations like inspecting intensities at coordinates within a frame.