Modal error message for empty string integer filter #198

Closed
qwesda opened this Issue Mar 24, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@qwesda

qwesda commented Mar 24, 2016

If you put an empty string as the input of a filter for an integer column you get this modal error message: Could not load table rows. The server said: invalid input syntax for integer: "".

Having an empty string as a filter makes of cause no sense, but this happens sometimes by hitting enter accidentally. Postico should just ignore these, not show an error message and load the rows as if no filter was set.

The modal dialog is even worse if it occurs in the foreign key row selector. The row selector closes immediately after the modal dialog sheet appears and there is no way of clearing the wrong filter. See attached gif:

modal dialog error

It is also confusing to me that Postico remembers the filters for tables and the foreign key row selector indefinitely. Postico should limit this to the current window. It's annoying to first remove any old filters, if you open a table that you worked in a week ago.

@qwesda

This comment has been minimized.

Show comment
Hide comment
@qwesda

qwesda May 10, 2016

I could get rid of the dialog by manipulating posticos db:

> sqlite3 ~/Library/Containers/at.eggerapps.Postico/Data/Library/Application\ Support/Postico/ConnectionFavorites.db

then enter

DELETE FROM ZPGEPREFCONTAINERPROPERTY WHERE ZTYPE = 4;

qwesda commented May 10, 2016

I could get rid of the dialog by manipulating posticos db:

> sqlite3 ~/Library/Containers/at.eggerapps.Postico/Data/Library/Application\ Support/Postico/ConnectionFavorites.db

then enter

DELETE FROM ZPGEPREFCONTAINERPROPERTY WHERE ZTYPE = 4;
@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob May 25, 2016

Owner

Thanks for reporting this issue; watching the GIF is slightly unnerving 😉

If fixed this now; Postico now displays the error message inline instead of a modal dialog.

This change will be in the next update, or you can download a dev build right now:
https://eggerapps-downloads.s3-eu-west-1.amazonaws.com/postico-1432.zip

Owner

jakob commented May 25, 2016

Thanks for reporting this issue; watching the GIF is slightly unnerving 😉

If fixed this now; Postico now displays the error message inline instead of a modal dialog.

This change will be in the next update, or you can download a dev build right now:
https://eggerapps-downloads.s3-eu-west-1.amazonaws.com/postico-1432.zip

@jakob jakob added the done label May 25, 2016

@jakob

This comment has been minimized.

Show comment
Hide comment
@jakob

jakob Jun 1, 2016

Owner

Fixed in 1.0.7

Owner

jakob commented Jun 1, 2016

Fixed in 1.0.7

@jakob jakob closed this Jun 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment