-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo/redo #34
Comments
@nielshoogendoorn thanks for the suggestion! Personally I think this could be advanced enough to be a separate library – I like things modular and I could imagine a solution with two canvases, you capture individual strokes on the top one, and copy them over to the bottom one on My question is: if there was to be a separate package – how would |
I'm interested in working on undo/redo, as well as adding some additional drawing tools and features (like line simplifying). Would you prefer I add those in my own branch only (and if so , would you like me to rename it to prevent confusion), or would you like PRs for these things? I think the two canvas thing you mention is how other tools manage. I think if we add more events into the Atrament drawing, then another tool could handle undo/redo. A bunch of what My overall goal is to use Atrament as the drawing component for an animation tool, with onionskinning and .gif export. |
@dethe this is great to hear, your use case is really cool. I'd be up for discussing the extra features you're proposing. My goal with Atrament is to make sure it conforms to "do one thing and do it well", but we already have the concept of different drawing modes (draw, fill, erase) so other tools could make sense, too. I think we can treat undo/redo as a separate feature & track it in this issue, and discuss additional drawing tools separately. If you're willing to collaborate on these, I'd be happy to add you as a co-author. Could you please drop me an email (on my GH profile) about the new features you were envisaging? thanks, Jakub |
Hi folks, just FYI Undo/redo is now possible to implement with Atrament 1.0.0 - see README, there is now a |
Would really appreciate an undo/redo feature.
I guess that in order for this to work, we need to
Any thoughts? Any volunteers? 😃
The text was updated successfully, but these errors were encountered: