-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include releases from artists whose songs I've saved #28
Comments
Thanks for sharing the idea, I like it! I'm the only developer/maintainer on this project - feel free to create a PR and I will be happy to merge it if it looks good. I don't see this in your outline above, but you will also have to ask for additional scope user-library-read, which makes it a little bit more complicated. Remember this scope has to be optional (only requested when the option is enabled). |
This is a great enhancement, but just a thought - personally I'd love to see a setting for minimum number of songs liked - in other words, I'm not interested in new releases for every artist who has one song I've liked, but if I've liked, say, three or five of their songs, then I'd want to include them. It would be great if the setting is fully customizable (i.e. I could pick any number I want - 3, 5, 7, 17, whatever). |
A great idea @somegirl, I'll make sure to include a setting for the minimum number of songs liked |
This is partially done in v3.1.0 |
Very nice! I was inspired to make a small donation. (If I ever hit the big bucks I'll make sure to give more. ;-) ) |
I'd love to see this as an enhancement and I'd be interested in adding the feature myself if it's something the maintainers would support!
This is a really neat platform, but I feel like it's of limited use to me since I typically save songs from artists that I like, and only rarely actually follow those artists.
I'm imagining a feature (perhaps disabled by default) where users can toggle to include artists whose songs they've saved. This would then: conditionally (upon enabling this setting) include those artists here to be included in the sync for new releases.
This would include:
getUserLikedSongsArtists
(perhaps with a better name 😅) method here that returns a list of the artists whose songs the user has liked. This would be in theapi.js
file:spotify-release-list/src/api.js
Line 48 in b67d20f
sync.js
to include the artists fromgetUserLikedSongsArtists
if the setting is enabled.spotify-release-list/src/sagas/sync.js
Line 70 in 74b53f4
Please let me know if you'd be interested in a PR for this functionality!
The text was updated successfully, but these errors were encountered: