Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: added PHP8.1 #123

Closed
wants to merge 1 commit into from
Closed

Fix: added PHP8.1 #123

wants to merge 1 commit into from

Conversation

bckp
Copy link

@bckp bckp commented Feb 5, 2022

No description provided.

@WyriHaximus
Copy link
Collaborator

Thank you for taking the time to create this PR, but as #106 has just been merged and also includes this I'm closing this PR.

@bckp
Copy link
Author

bckp commented Mar 16, 2022

You have added tests etc, but do not edited composer.json, so PHP8.1 is still not supported from Composer perspective....
see https://getcomposer.org/doc/articles/versions.md#caret-version-range-

@WyriHaximus

@WyriHaximus
Copy link
Collaborator

@bckp It installs just fine on PHP 8.1 for me:
image

And looking at that caret explanation it also matches PHP 8.1. Or are you experiencing something different?

@bckp
Copy link
Author

bckp commented Mar 16, 2022

Hmm, now installs fine... Sorry, it must be some dependency issue, as for me it always install 0.2.4... thanks @WyriHaximus

@WyriHaximus
Copy link
Collaborator

Don't hesitate to reach out if you run into any issues in the future

@bckp bckp deleted the issue-php81 branch March 17, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants