Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved PCNTL extension to require-dev and suggest composer sections #130

Merged
merged 1 commit into from Dec 15, 2022
Merged

Conversation

kukulich
Copy link
Contributor

@kukulich kukulich commented Dec 13, 2022

It's required only for tests and synchronous client and it blocks installation on Windows now.

It's required only for tests and synchronous client
@WyriHaximus WyriHaximus added this to the v0.5.4 milestone Dec 15, 2022
Copy link
Collaborator

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I do think it should be there because it is used in the sync client, including in patch release is a BC break that only affects Windows. Will release this right after merging

@WyriHaximus WyriHaximus merged commit 1f6c8f2 into jakubkulhan:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants