implode() deprecated in PHP 7.4

[yngveo]

I have updated my dev environment to PHP 7.4 and am now getting an exception when running Tab->devtools();

The error occurs in Protocol.php line 330 - implode().

Error message:

implode(): Passing glue string after array is deprecated. Swap the parameters

[xsuchy09]

This is bug in wrench/wrench library (varspool/Wrench#128, varspool/Wrench#129, ...). Now fixed in master but still not new version. So in v2.0.8 there is this deprecated error in wrench/wrench required library. There is wrench v3.0 with fix but it is still not stable ... but maybe update this library to v3.0 can help (but there can be incompatible issues - new major version) ...

composer require wrench/wrench ~3.0

edit: Yes, there are incompatible issues ...

[jakubkulhan]

Hi, I've pushed a new version fix release that depends on PR created by @wells. Hopefully, the fix will be merged soon to the upstream.

[wells]

Thanks @jakubkulhan

Looks like we may be able to get 3.* tagged on wrench with a proper assist to get that across the finish line. Hopefully no breaking changes involved apart from phpunit / php versioning.

[wells]

@jakubkulhan, I was able to use dev-master of wrench without issue on php 7.4. This is not a definitive end-to-end test, but I made a forked branch of this package to take a test drive. Let's hope 3.0 of wrench gets tagged soon.

[kondaurov]

Hi @jakubkulhan
Is it possible to wait for a release with a commit fixes for PHP 7.4 in the near future?

[jakubkulhan]

@kondaurov Until Websocket library merges this PR varspool/Wrench#130 and tags a release, I cannot create tagged release here.

[iwiznia]

Websocket released version 2.0 with the fix merged. Can we get a release with the dependency updated please?

[wells]

I concur. @jakubkulhan can we get a tagged release for this repo, now that v2.0.11 has my pull request merged on wrench? Thanks.

[jakubkulhan]

Tagged as https://github.com/jakubkulhan/chrome-devtools-protocol/releases/tag/v1.0.3

[wells]

@jakubkulhan You may also want to remove this from your composer.json

"repositories": [
    {
      "type": "vcs",
      "url": "https://github.com/wells/Wrench.git"
    }
  ]

[jakubkulhan]

@wells Good point, thanks! Removed.

[iwiznia]

Thank you!!

[wells]

Sorry to be a bother. @jakubkulhan, could you either move the v1.0.3 tag to commit 95fcaa3 or tag a new release?

[jakubkulhan]

@wells Sure, tagged as v1.0.4.