Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix php 7.4 compatibility problem related to implode() #129

Merged
merged 3 commits into from
Jun 9, 2020

Conversation

ekharchenko-avito
Copy link

Fix php7.4 deprecation warning for 2.* branch

implode(): Passing glue string after array is deprecated. Swap the parameters

@ekharchenko-avito ekharchenko-avito changed the title Fix php 7.4 compatibility problem with implode() Fix php 7.4 compatibility problem related to implode() Feb 11, 2020
@nexen2
Copy link
Contributor

nexen2 commented Feb 21, 2020

Do you use old 2.0 branch? Its PHP 5.0 related. Try out master branch, it has already "implode" function fixed.

@ekharchenko-avito
Copy link
Author

ekharchenko-avito commented Mar 4, 2020

Do you use old 2.0 branch? Its PHP 5.0 related. Try out master branch, it has already "implode" function fixed.

Well, I see 3.0.0 is unstable here https://github.com/varspool/Wrench and here https://packagist.org/packages/wrench/wrench .
Before 3.0.0 release is available, latest stable version is 2.0.8 (currently).
Can't see any reasons not to fix php 7.4 compatibility in stable branch.

@tanyabrytkova
Copy link

@nexen2 could you please help us merge this PR and tag it with 2.0.9 tag?

@tanyabrytkova
Copy link

tanyabrytkova commented Mar 9, 2020

Hi @nexen2,
Unfortunately, we cannot use your fixes from the latest master since it wasn't tagged (our system allows to add packages to composer using tags only).

Could you please tag your master branch with 2.0.9 tag? or at least 3.0 if there are any breaking changes you're aware of

@damnedest
Copy link

@nexen2 is there any news about tagging release?

@enumag
Copy link

enumag commented May 11, 2020

ping @nexen2

@ekharchenko-avito
Copy link
Author

For those with the same problem.
We solved by using patched version as a dependency.
You may route composer to your patched repo instead of primary packagist upstream with the repositories section in composer.json.

@djschilling
Copy link

i also need this.

@dominics dominics merged commit db89efb into varspool:2.0 Jun 9, 2020
@dominics
Copy link
Member

dominics commented Jun 9, 2020

I've merged all the outstanding PRs, and given them pre-release versions as 2.0.9-rc1 through 2.0.11-rc1 (although there's probably no functional difference between some of them)

Marked master as 3.0.0-rc1

Will circle back to make all of that stable soon unless I hear of problems here.

@dominics dominics self-assigned this Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

7 participants