-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix php 7.4 compatibility problem related to implode() #129
Conversation
add checks on 7.4
Do you use old 2.0 branch? Its PHP 5.0 related. Try out master branch, it has already "implode" function fixed. |
Well, I see 3.0.0 is unstable here https://github.com/varspool/Wrench and here https://packagist.org/packages/wrench/wrench . |
@nexen2 could you please help us merge this PR and tag it with 2.0.9 tag? |
Hi @nexen2, Could you please tag your master branch with 2.0.9 tag? or at least 3.0 if there are any breaking changes you're aware of |
@nexen2 is there any news about tagging release? |
ping @nexen2 |
For those with the same problem. |
i also need this. |
I've merged all the outstanding PRs, and given them pre-release versions as 2.0.9-rc1 through 2.0.11-rc1 (although there's probably no functional difference between some of them) Marked master as 3.0.0-rc1 Will circle back to make all of that stable soon unless I hear of problems here. |
Fix php7.4 deprecation warning for 2.* branch