-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not to strip quotes in url #611
Comments
Can you provide an example page (jsfiddle, etc) so it can be retested in different browsers? In which browser it fails btw? |
I made test in github.io because of font file common index.html<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<link rel="stylesheet" href="styles/style.css">
<title>font-face</title>
</head>
<body>
<div id = "test">
<h2>#TEXT</h2>
</div>
</body>
</html> font-face-example1 style.css (success)http://zeakd.github.io/font-face-example1/@font-face {
font-family: "BebasNeue";
font-weight: bold;
font-style : normal;
src: url('/font-face-example1/fonts/BebasNeue Bold.eot');
src:local("☺"),
url("/font-face-example1/fonts/BebasNeue Bold.woff") format("woff"),
url("/font-face-example1/fonts/BebasNeue Bold.otf") format("opentype");
}
#test {
font: 12px/26px BebasNeue;
} font-face-example2 style.css (fail)http://zeakd.github.io/font-face-example2/@font-face {
font-family: "BebasNeue";
font-weight: bold;
font-style : normal;
src: url(/font-face-example2/fonts/BebasNeue Bold.eot);
src:local("☺"),
url(/font-face-example2/fonts/BebasNeue Bold.woff) format("woff"),
url(/font-face-example2/fonts/BebasNeue Bold.otf) format("opentype");
}
#test {
font: 12px/26px BebasNeue;
} I don't know why example2 doesn't send font get request. I knew quote in url is option... |
It manifested itself when rebasing to a relative or absolute path only.
Fixed in 3.3.4 - it was a combination of URL rebasing, rewriting, and whitespace which there were no test for. |
Thanks! |
👍 for reporting! |
Hi.
I write this code and it works, but when I strip quotes like this
and it doesn't work. no request send.
so I want not to remove that quotes.
and I did
even I changed all urlQuotes property to true in lib/compatibility.js but it still remove my quotes. how can I leave these?
The text was updated successfully, but these errors were encountered: